Issue 85463002: Web Animations: Remove WebAnimations runtime feature in favor of WebAnimationsCSS

Issue 85463002: Web Animations: Remove WebAnimations runtime feature in favor of WebAnimationsCSS (Closed)

Created:
7 years ago by dstockwell

Modified:
7 years ago

Reviewers:
Steve Block, abarth-chromium

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), zoltan1, eae+blinkwatch, dglazkov+blink, leviw+renderwatch, blink-layers+watch_chromium.org, dstockwell, Timothy Loh, adamk+blink_chromium.org, jchaffraix+rendering, darktears, bemjb+rendering_chromium.org, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations: Remove WebAnimations runtime feature in favor of WebAnimationsCSS The WebAnimations and WebAnimationsCSS flags were not used consistently. As WebAnimationsCSS is approaching shipping we can block other Web Animations features behind it. R=steveblock TBR=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162890

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -54 lines)			Patch
M	Source/core/animation/CompositorAnimationsTestHelper.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsTimingFunctionReverserTest.cpp	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	Source/core/animation/DocumentAnimations.cpp	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/Document.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/platform/animation/TimingFunction.h	View		4 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/core/platform/animation/TimingFunctionTestHelperTest.cpp	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/core/rendering/CompositedLayerMapping.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayer.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderLayerCompositor.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/web/WebRuntimeFeatures.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Steve Block

https://codereview.chromium.org/85463002/diff/1/Source/core/animation/CompositorAnimationsTestHelper.h File Source/core/animation/CompositorAnimationsTestHelper.h (left): https://codereview.chromium.org/85463002/diff/1/Source/core/animation/CompositorAnimationsTestHelper.h#oldcode148 Source/core/animation/CompositorAnimationsTestHelper.h:148: RuntimeEnabledFeatures::setWebAnimationsEnabled(true); Why is this no longer required? The ChainedTimingFunction ...

7 years ago (2013-11-26 05:37:21 UTC) #2

dstockwell

https://codereview.chromium.org/85463002/diff/1/Source/core/animation/CompositorAnimationsTestHelper.h File Source/core/animation/CompositorAnimationsTestHelper.h (left): https://codereview.chromium.org/85463002/diff/1/Source/core/animation/CompositorAnimationsTestHelper.h#oldcode148 Source/core/animation/CompositorAnimationsTestHelper.h:148: RuntimeEnabledFeatures::setWebAnimationsEnabled(true); On 2013/11/26 05:37:22, Steve Block wrote: > Why ...

7 years ago (2013-11-26 05:59:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/85463002/40001

7 years ago (2013-11-29 08:11:39 UTC) #5

Message was sent while issue was closed.

Change committed as 162890

Expand Messages | Collapse Messages