Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: sky/engine/core/rendering/line/LineLayoutState.h

Issue 854563005: Remove some unused paint invalidation members from RenderObject. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: add a bit more Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderParagraph.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/line/LineLayoutState.h
diff --git a/sky/engine/core/rendering/line/LineLayoutState.h b/sky/engine/core/rendering/line/LineLayoutState.h
index 9d49df4c30ac0917c590e26cd549ee5f9ab00c92..e25b2a0ec3e94303b2004bca407f0f45cb7a24cf 100644
--- a/sky/engine/core/rendering/line/LineLayoutState.h
+++ b/sky/engine/core/rendering/line/LineLayoutState.h
@@ -33,7 +33,7 @@ namespace blink {
// during an entire linebox tree layout pass (aka RenderParagraph::layoutChildren).
class LineLayoutState {
public:
- LineLayoutState(bool fullLayout, LayoutUnit& paintInvalidationLogicalTop, LayoutUnit& paintInvalidationLogicalBottom)
+ LineLayoutState(bool fullLayout)
: m_lastFloat(0)
, m_endLine(0)
, m_floatIndex(0)
@@ -42,30 +42,12 @@ public:
, m_checkForFloatsFromLastLine(false)
, m_hasInlineChild(false)
, m_isFullLayout(fullLayout)
- , m_paintInvalidationLogicalTop(paintInvalidationLogicalTop)
- , m_paintInvalidationLogicalBottom(paintInvalidationLogicalBottom)
, m_adjustedLogicalLineTop(0)
- , m_usesPaintInvalidationBounds(false)
{ }
void markForFullLayout() { m_isFullLayout = true; }
bool isFullLayout() const { return m_isFullLayout; }
- bool usesPaintInvalidationBounds() const { return m_usesPaintInvalidationBounds; }
-
- void setPaintInvalidationRange(LayoutUnit logicalHeight)
- {
- m_usesPaintInvalidationBounds = true;
- m_paintInvalidationLogicalTop = m_paintInvalidationLogicalBottom = logicalHeight;
- }
-
- void updatePaintInvalidationRangeFromBox(RootInlineBox* box, LayoutUnit paginationDelta = 0)
- {
- m_usesPaintInvalidationBounds = true;
- m_paintInvalidationLogicalTop = std::min(m_paintInvalidationLogicalTop, box->logicalTopVisualOverflow() + std::min<LayoutUnit>(paginationDelta, 0));
- m_paintInvalidationLogicalBottom = std::max(m_paintInvalidationLogicalBottom, box->logicalBottomVisualOverflow() + std::max<LayoutUnit>(paginationDelta, 0));
- }
-
bool endLineMatched() const { return m_endLineMatched; }
void setEndLineMatched(bool endLineMatched) { m_endLineMatched = endLineMatched; }
@@ -110,13 +92,7 @@ private:
bool m_isFullLayout;
- // FIXME: Should this be a range object instead of two ints?
- LayoutUnit& m_paintInvalidationLogicalTop;
- LayoutUnit& m_paintInvalidationLogicalBottom;
-
LayoutUnit m_adjustedLogicalLineTop;
-
- bool m_usesPaintInvalidationBounds;
};
}
« no previous file with comments | « sky/engine/core/rendering/RenderParagraph.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698