android_webview/common/print_messages.h - Issue 854513002: Remove the discrepencies between chrome and android_webview print

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/common/print_messages.h

Issue 854513002: Remove the discrepencies between chrome and android_webview print (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address code review Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/aw_printing_message_filter.cc ('K') | « android_webview/browser/renderer_host/print_manager.cc ('k') | android_webview/native/aw_pdf_exporter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/common/print_messages.h

diff --git a/android_webview/common/print_messages.h b/android_webview/common/print_messages.h

index 6feeec7eccc84482ec2b2c04ccb725fb50ec89d1..294241b0ee0db7081a7d2b530658214a2b7fb95c 100644

--- a/android_webview/common/print_messages.h

+++ b/android_webview/common/print_messages.h

@@ -376,11 +376,13 @@ IPC_SYNC_MESSAGE_ROUTED1_1(PrintHostMsg_ScriptedPrint,

#if defined(OS_ANDROID)

// Asks the browser to create a temporary file for the renderer to fill

// in resulting PdfMetafileSkia in printing.

-IPC_SYNC_MESSAGE_ROUTED0_2(PrintHostMsg_AllocateTempFileForPrinting,

- base::FileDescriptor /* temp file fd */,

- int /* fd in browser*/)

-IPC_MESSAGE_ROUTED1(PrintHostMsg_TempFileForPrintingWritten,

- int /* fd in browser */)

+IPC_SYNC_MESSAGE_CONTROL1_2(PrintHostMsg_AllocateTempFileForPrinting,

+ int /* render_view_id */,

nasko 2015/01/14 19:16:33 Unless you have a really good reason, don't use Re

sgurun-gerrit only 2015/01/14 19:35:20 This file is a direct replica of print_messages.h

+ base::FileDescriptor /* temp file fd */,

+ int /* fd in browser*/)

+IPC_MESSAGE_CONTROL2(PrintHostMsg_TempFileForPrintingWritten,

+ int /* render_view_id */,

+ int /* fd in browser */)

#endif

// Asks the browser to do print preview.

IPC_MESSAGE_ROUTED1(PrintHostMsg_RequestPrintPreview,