Remove the discrepencies between chrome and android_webview print

android_webview/common/print_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for printing.
 // Multiply-included message file, hence no include guard.
 
 // TODO(sgurun) copied from chrome/common. Remove after crbug.com/322276
 
 #include <string>
@@ skipping 358 matching lines @@
 // final print settings. The output parameter is the same as
 // ViewMsg_PrintPages which is executed implicitly.
 IPC_SYNC_MESSAGE_ROUTED1_1(PrintHostMsg_ScriptedPrint,
                            PrintHostMsg_ScriptedPrint_Params,
                            PrintMsg_PrintPages_Params
                                /* settings chosen by the user*/)
 
 #if defined(OS_ANDROID)
 // Asks the browser to create a temporary file for the renderer to fill
 // in resulting PdfMetafileSkia in printing.
-IPC_SYNC_MESSAGE_ROUTED0_2(PrintHostMsg_AllocateTempFileForPrinting,
-                           base::FileDescriptor /* temp file fd */,
-                           int /* fd in browser*/)
-IPC_MESSAGE_ROUTED1(PrintHostMsg_TempFileForPrintingWritten,
-                    int /* fd in browser */)
+IPC_SYNC_MESSAGE_CONTROL1_2(PrintHostMsg_AllocateTempFileForPrinting,
+                            int /* render_view_id */,

[nasko, 2015/01/14 19:16:33]

Unless you have a really good reason, don't use RenderView(Host) routing ids.
Use the top-level RenderFrame(Host) routing id.

[sgurun-gerrit only, 2015/01/14 19:35:20]

This file is a direct replica of print_messages.h in chrome layer:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/prin...

We are now componentizing it remove the duplicate code. I think it is better for
printing folks to address it after moving it to components.

+                            base::FileDescriptor /* temp file fd */,
+                            int /* fd in browser*/)
+IPC_MESSAGE_CONTROL2(PrintHostMsg_TempFileForPrintingWritten,
+                     int /* render_view_id */,
+                     int /* fd in browser */)
 #endif
 // Asks the browser to do print preview.
 IPC_MESSAGE_ROUTED1(PrintHostMsg_RequestPrintPreview,
                     PrintHostMsg_RequestPrintPreview_Params /* params */)
 
 // Notify the browser the number of pages in the print preview document.
 IPC_MESSAGE_ROUTED1(PrintHostMsg_DidGetPreviewPageCount,
                     PrintHostMsg_DidGetPreviewPageCount_Params /* params */)
 
 // Notify the browser of the default page layout according to the currently
@@ skipping 45 matching lines @@
 IPC_SYNC_MESSAGE_ROUTED0_0(PrintHostMsg_SetupScriptedPrintPreview)
 
 // Tell the browser to show the print preview, when the document is sufficiently
 // loaded such that the renderer can determine whether it is modifiable or not.
 IPC_MESSAGE_ROUTED1(PrintHostMsg_ShowScriptedPrintPreview,
                     bool /* is_modifiable */)
 
 // Notify the browser that the PDF in the initiator renderer has disabled print
 // scaling option.
 IPC_MESSAGE_ROUTED0(PrintHostMsg_PrintPreviewScalingDisabled)