Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 854453003: Revert of Revert of Reland factor out window proxy management portions of ScriptController. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland factor out window proxy management portions of ScriptController. Right now, ScriptController is in charge of initializing window proxies, clearing them for navigation/close, and maintaining a mapping of worlds to window proxies. However, ScriptController is LocalFrame-specific, and RemoteFrame also needs to expose a DOMWindow for scripting purposes. To share code between the two, the window proxy management has been moved out of ScriptController, leaving only LocalFrame-specific logic such as wrapping NPObject for plugins or script evaluation. Eventually, RemoteFrame will also embed a WindowProxyManager, and WindowProxyManager will be extended to allow it be passed between frames when transitioning between local and remote frames. For integration with devtools, WindowProxyManager still contains some LocalFrame-specific code. BUG=425623 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188574

Patch Set 1 #

Patch Set 2 : Rebase and deflake test #

Total comments: 4

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -135 lines) Patch
A LayoutTests/fast/dom/defaultView-on-detached-document.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/defaultView-on-detached-document-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/NPV8Object.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.h View 1 3 chunks +6 lines, -9 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 1 21 chunks +78 lines, -122 lines 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
A Source/bindings/core/v8/WindowProxyManager.h View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/WindowProxyManager.cpp View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
dcheng
Created Revert of Revert of Reland factor out window proxy management portions of ScriptController.
5 years, 11 months ago (2015-01-16 03:29:13 UTC) #1
dcheng
5 years, 11 months ago (2015-01-16 03:29:24 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-16 03:41:20 UTC) #3
dcheng
PTAL. I've rebased to ToT in Blink and deflaked the layout test. Since this isn't ...
5 years, 11 months ago (2015-01-16 04:32:29 UTC) #6
haraken
LGTM https://codereview.chromium.org/854453003/diff/230001/Source/bindings/core/v8/WindowProxyManager.h File Source/bindings/core/v8/WindowProxyManager.h (right): https://codereview.chromium.org/854453003/diff/230001/Source/bindings/core/v8/WindowProxyManager.h#newcode1 Source/bindings/core/v8/WindowProxyManager.h:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 11 months ago (2015-01-16 04:55:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/854453003/250001
5 years, 11 months ago (2015-01-17 00:31:36 UTC) #9
dcheng
https://codereview.chromium.org/854453003/diff/230001/Source/bindings/core/v8/WindowProxyManager.h File Source/bindings/core/v8/WindowProxyManager.h (right): https://codereview.chromium.org/854453003/diff/230001/Source/bindings/core/v8/WindowProxyManager.h#newcode1 Source/bindings/core/v8/WindowProxyManager.h:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 11 months ago (2015-01-17 00:33:05 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:250001) as https://src.chromium.org/viewvc/blink?view=rev&revision=188574
5 years, 11 months ago (2015-01-17 02:13:21 UTC) #11
dcheng
5 years, 11 months ago (2015-01-20 18:31:01 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:250001) has been created in
https://codereview.chromium.org/834203003/ by dcheng@chromium.org.

The reason for reverting is: Needed data gathered, so reverting to reduce number
of crash dumps..

Powered by Google App Engine
This is Rietveld 408576698