services/icu_data/icu_data_impl.cc - Issue 854433002: Update the sha1hash of the ICU data table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/icu_data/icu_data_impl.cc

Issue 854433002: Update the sha1hash of the ICU data table (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/icu_data/icu_data_impl.cc

diff --git a/services/icu_data/icu_data_impl.cc b/services/icu_data/icu_data_impl.cc

index af6d99edb6b65a51c51c64edc58e632b7bb84247..c171a11732f19f77ca3afc91e4a60b5f2237af79 100644

--- a/services/icu_data/icu_data_impl.cc

+++ b/services/icu_data/icu_data_impl.cc

@@ -38,6 +38,7 @@ class ICUDataImpl : public mojo::ApplicationDelegate,

const mojo::Callback<void(mojo::ScopedSharedBufferHandle)>& callback)

override {

if (std::string(sha1hash) != std::string(kICUDataTableHash)) {

+ LOG(INFO) << "Failed to match sha1sum. Expected " << kICUDataTableHash;

eseidel 2015/01/13 20:22:43 LOG(FATAL)?

callback.Run(mojo::ScopedSharedBufferHandle());

return;

}

« no previous file with comments | « services/icu_data/embed_icu_data.py ('k') | no next file » | no next file with comments »