services/icu_data/embed_icu_data.py - Issue 854433002: Update the sha1hash of the ICU data table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/icu_data/embed_icu_data.py

Issue 854433002: Update the sha1hash of the ICU data table (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/icu_data/embed_icu_data.py

diff --git a/services/icu_data/embed_icu_data.py b/services/icu_data/embed_icu_data.py

index 0ffbacee8288d6114b438fd3c87ee3ca65537358..515a3bb767b95ee9f11f53b88573460894c24831 100755

--- a/services/icu_data/embed_icu_data.py

+++ b/services/icu_data/embed_icu_data.py

@@ -30,7 +30,7 @@ for i in range(0, len(values), chunk_size):

with open(out_file, "w") as f:

f.write('#include "services/icu_data/data.h"\n')

f.write("namespace icu_data {\n")

- f.write("const char kICUDataTable[] = {\n")

+ f.write("const char kICUDataTable[%d] = {\n" % len(data))

f.write(",\n".join(lines))

f.write("\n};\n")

f.write("const size_t kICUDataTableSize = sizeof(kICUDataTable);\n")