Issue 854433002: Update the sha1hash of the ICU data table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 854433002: Update the sha1hash of the ICU data table (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Update the sha1hash of the ICU data table R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9273eef90778af8429c5569e914708d42060396d

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	mojo/icu/icu.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	services/icu_data/embed_icu_data.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	services/icu_data/icu_data_impl.cc	View	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/854433002/diff/1/services/icu_data/icu_data_impl.cc File services/icu_data/icu_data_impl.cc (right): https://codereview.chromium.org/854433002/diff/1/services/icu_data/icu_data_impl.cc#newcode41 services/icu_data/icu_data_impl.cc:41: LOG(INFO) << "Failed to match sha1sum. Expected " ...

5 years, 11 months ago (2015-01-13 20:22:44 UTC) #2

abarth-chromium

5 years, 11 months ago (2015-01-13 20:27:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9273eef90778af8429c5569e914708d42060396d (presubmit successful).

Expand Messages | Collapse Messages