src/gpu/gl/builders/GrGLVertexShaderBuilder.h - Issue 854013002: Refactor position computation to enable device space "nudge"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/builders/GrGLVertexShaderBuilder.h

Issue 854013002: Refactor position computation to enable device space "nudge" (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update to ToT Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/builders/GrGLVertexShaderBuilder.h

diff --git a/src/gpu/gl/builders/GrGLVertexShaderBuilder.h b/src/gpu/gl/builders/GrGLVertexShaderBuilder.h

index 355f37e3610cffcdedb0768f02e35168ed86ec04..4c99a7b728b43b5cb0e454af42f4bd06d17e0603 100644

--- a/src/gpu/gl/builders/GrGLVertexShaderBuilder.h

+++ b/src/gpu/gl/builders/GrGLVertexShaderBuilder.h

@@ -16,7 +16,7 @@ class GrGLVertexBuilder : public GrGLShaderBuilder {

public:

GrGLVertexBuilder(GrGLProgramBuilder* program);

- void transformToNormalizedDeviceSpace(const char* pos3);

+ void transformToNormalizedDeviceSpace(const GrShaderVar& posVar);

void emitAttributes(const GrGeometryProcessor& gp);

void addAttribute(const GrGeometryProcessor::Attribute* attr) {