Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8539047: Add OVERRIDE to webkit/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, michaeln, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, kinuko+watch, scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Add OVERRIDE to webkit/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110357

Patch Set 1 #

Patch Set 2 : missing header #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -274 lines) Patch
M webkit/appcache/appcache_disk_cache.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_frontend_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_interceptor.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_response.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_storage_impl.h View 1 chunk +22 lines, -17 lines 0 comments Download
M webkit/appcache/appcache_update_job.h View 2 chunks +9 lines, -8 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 3 chunks +13 lines, -10 lines 0 comments Download
M webkit/appcache/mock_appcache_policy.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/appcache/mock_appcache_service.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/appcache/mock_appcache_storage.h View 1 chunk +22 lines, -15 lines 0 comments Download
M webkit/blob/blob_url_request_job.h View 1 chunk +10 lines, -7 lines 0 comments Download
M webkit/blob/view_blob_internals_job.h View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/database/database_quota_client.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.h View 1 chunk +7 lines, -5 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.h View 1 chunk +12 lines, -8 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/glue/media/buffered_data_source.h View 1 chunk +16 lines, -14 lines 0 comments Download
M webkit/glue/media/simple_data_source.h View 1 2 2 chunks +14 lines, -12 lines 0 comments Download
M webkit/glue/media/web_data_source_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/plugin_stream_url.h View 2 chunks +13 lines, -11 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_arguments_test.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_delete_plugin_in_deallocate_test.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_delete_plugin_in_stream_test.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url2_test.h View 1 2 2 chunks +10 lines, -7 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_get_javascript_url_test.h View 1 2 2 chunks +10 lines, -7 lines 0 comments Download
webkit/plugins/npapi/test/plugin_geturl_test.h View 2 chunks +11 lines, -9 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_javascript_open_popup.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_new_fails_test.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_identity_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_npobject_proxy_test.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_private_test.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_schedule_timer_test.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_setup_test.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/npapi/test/plugin_thread_async_call_test.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_window_size_test.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_windowless_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/webplugin_delegate_impl.h View 1 chunk +19 lines, -18 lines 0 comments Download
M webkit/plugins/npapi/webplugin_impl.h View 2 chunks +21 lines, -18 lines 0 comments Download
M webkit/quota/mock_special_storage_policy.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webkit/support/simple_database_system.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/support/test_webplugin_page_delegate.h View 1 chunk +9 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/accessibility_ui_element.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell_request_context.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_test.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webmimeregistry_impl.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Just adding OVERRIDEs.
9 years, 1 month ago (2011-11-16 17:36:53 UTC) #1
darin (slow to review)
OK, LGTM
9 years, 1 month ago (2011-11-16 18:26:30 UTC) #2
Avi (use Gerrit)
Fixed clang plugin to properly detect WebKit. PTAL.
9 years, 1 month ago (2011-11-16 21:17:56 UTC) #3
darin (slow to review)
9 years, 1 month ago (2011-11-16 21:24:27 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698