Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: webkit/plugins/npapi/test/plugin_javascript_open_popup.h

Issue 8539047: Add OVERRIDE to webkit/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_NPAPI_TEST_PLUGIN_JAVASCRIPT_OPEN_POPUP_H_ 5 #ifndef WEBKIT_PLUGINS_NPAPI_TEST_PLUGIN_JAVASCRIPT_OPEN_POPUP_H_
6 #define WEBKIT_PLUGINS_NPAPI_TEST_PLUGIN_JAVASCRIPT_OPEN_POPUP_H_ 6 #define WEBKIT_PLUGINS_NPAPI_TEST_PLUGIN_JAVASCRIPT_OPEN_POPUP_H_
7 7
8 #include "base/compiler_specific.h"
8 #include "webkit/plugins/npapi/test/plugin_test.h" 9 #include "webkit/plugins/npapi/test/plugin_test.h"
9 10
10 namespace NPAPIClient { 11 namespace NPAPIClient {
11 12
12 // This class tests the case where a windowed plugin instance is 13 // This class tests the case where a windowed plugin instance is
13 // instantiated in a popup window. The plugin instance needs to 14 // instantiated in a popup window. The plugin instance needs to
14 // have a valid parent window. 15 // have a valid parent window.
15 class ExecuteJavascriptOpenPopupWithPluginTest : public PluginTest { 16 class ExecuteJavascriptOpenPopupWithPluginTest : public PluginTest {
16 public: 17 public:
17 // Constructor. 18 // Constructor.
18 ExecuteJavascriptOpenPopupWithPluginTest( 19 ExecuteJavascriptOpenPopupWithPluginTest(
19 NPP id, NPNetscapeFuncs *host_functions); 20 NPP id, NPNetscapeFuncs *host_functions);
20 // NPAPI SetWindow handler. 21 // NPAPI SetWindow handler.
21 virtual NPError SetWindow(NPWindow* window); 22 virtual NPError SetWindow(NPWindow* window) OVERRIDE;
22 23
23 private: 24 private:
24 bool popup_window_test_started_; 25 bool popup_window_test_started_;
25 }; 26 };
26 27
27 // This class represents a windowed plugin instance instantiated within a 28 // This class represents a windowed plugin instance instantiated within a
28 // popup window. It verifies that the plugin instance has a valid parent. 29 // popup window. It verifies that the plugin instance has a valid parent.
29 class ExecuteJavascriptPopupWindowTargetPluginTest : public PluginTest { 30 class ExecuteJavascriptPopupWindowTargetPluginTest : public PluginTest {
30 public: 31 public:
31 ExecuteJavascriptPopupWindowTargetPluginTest( 32 ExecuteJavascriptPopupWindowTargetPluginTest(
32 NPP id, NPNetscapeFuncs *host_functions); 33 NPP id, NPNetscapeFuncs *host_functions);
33 // NPAPI SetWindow handler. 34 // NPAPI SetWindow handler.
34 virtual NPError SetWindow(NPWindow* window); 35 virtual NPError SetWindow(NPWindow* window) OVERRIDE;
35 36
36 private: 37 private:
37 // Do a platform-specific validation of the passed-in |window|. 38 // Do a platform-specific validation of the passed-in |window|.
38 // E.g. on Windows, verifies window->window is a reasonable HWND. 39 // E.g. on Windows, verifies window->window is a reasonable HWND.
39 // Returns true if the test should be marked complete. 40 // Returns true if the test should be marked complete.
40 bool CheckWindow(NPWindow* window); 41 bool CheckWindow(NPWindow* window);
41 42
42 bool test_completed_; 43 bool test_completed_;
43 }; 44 };
44 45
45 } // namespace NPAPIClient 46 } // namespace NPAPIClient
46 47
47 #endif // WEBKIT_PLUGINS_NPAPI_TEST_PLUGIN_JAVASCRIPT_OPEN_POPUP_H_ 48 #endif // WEBKIT_PLUGINS_NPAPI_TEST_PLUGIN_JAVASCRIPT_OPEN_POPUP_H_
OLDNEW
« no previous file with comments | « webkit/plugins/npapi/test/plugin_geturl_test.h ('k') | webkit/plugins/npapi/test/plugin_new_fails_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698