Refactor ProfileInfoCache

Refactor ProfileInfoCache

There are a couple of problems with ProfileInfoCache that I'd like to fix in this CL:
 - currently profile information is accessed by index which is very fragile
 - the sorted list of profiles can be difficult to maintain
 - there's lots of repetitive code when adding new fields to the cache
 - information is looked up from preferences each time. this mean there's no easy to way to keep a copy of the value for quick retrieval

These capabilities are going to be important in my next CL where I'm adding 4 new fields to the cache.

At a high level this CL fixes the above problems by doing the following:
  - move the profile information into a separate Entry class
  - don't maintain a sorted list of profiles. Instead, just build the sorted list on demand.

BUG=91241
TEST=

[sail, 2011-11-16 09:30:38]

This is not quite ready for review but I'm sending this out early to get some
design feedback. Particularly, please take a look at everything in profiles/*

FYI the GAIA related code that uses these change will be out for review later
today. My goal is to get all the code for this feature out for review by end of
day and landed by end of week.

Thanks

[Miranda Callahan, 2011-11-16 14:43:20]

On 2011/11/16 09:30:38, sail wrote:
> This is not quite ready for review but I'm sending this out early to get some
> design feedback. Particularly, please take a look at everything in profiles/*
> 
> FYI the GAIA related code that uses these change will be out for review later
> today. My goal is to get all the code for this feature out for review by end
of
> day and landed by end of week.
> 
> Thanks

Sailesh, I really, really like refactoring this messy class, but please look at
this CL I'm about to send out for review:
http://codereview.chromium.org/8502033/

This adds the desktop shortcuts for Windows, and needs to get in this week --
and adds lots of code to the ProfileInfoCache. :-(

Would you mind holding off until the shortcuts have landed? Sigh.

[sail, 2011-11-16 15:23:24]

> Would you mind holding off until the shortcuts have landed? Sigh.

Ahh, I'm also adding a bunch of stuff to this class too:
http://codereview.chromium.org/8511064/diff/31/chrome/browser/profiles/profil...

Waiting till next week sounds like a plan. It'll probably help me as well.

Thanks!

[Miranda Callahan, 2011-11-16 15:43:21]

On 2011/11/16 15:23:24, sail wrote:
> > Would you mind holding off until the shortcuts have landed? Sigh.
> 
> Ahh, I'm also adding a bunch of stuff to this class too:
>
http://codereview.chromium.org/8511064/diff/31/chrome/browser/profiles/profil...
> 
> Waiting till next week sounds like a plan. It'll probably help me as well.
> 
> Thanks!

Ha, it looks like this week is ProfileInfoCache Celebration Week! ;-)  

Ok, that's great -- I really appreciate it! I'm in the "add tests" phase of my
CL right now -- you should see the review coming soon...