Refactor ProfileInfoCache

chrome/browser/profiles/avatar_menu_model.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/avatar_menu_model.h"
 
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/avatar_menu_model_observer.h"
@@ skipping 59 matching lines @@
     : icon(icon),
       active(false),
       model_index(model_index) {
 }
 
 AvatarMenuModel::Item::~Item() {
 }
 
 void AvatarMenuModel::SwitchToProfile(size_t index) {
   const Item& item = GetItemAt(index);
-  FilePath path = profile_info_->GetPathOfProfileAtIndex(item.model_index);
 
   // This will be deleted by the manager after the profile is ready.
   ProfileSwitchObserver* observer = new ProfileSwitchObserver();
   g_browser_process->profile_manager()->CreateProfileAsync(
-      path, observer);
+      item.path, observer);
   ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::SWITCH_PROFILE_ICON);
 }
 
 void AvatarMenuModel::EditProfile(size_t index) {
   Browser* browser = browser_;
   if (!browser) {
     Profile* profile = g_browser_process->profile_manager()->GetProfileByPath(
-        profile_info_->GetPathOfProfileAtIndex(GetItemAt(index).model_index));
+        GetItemAt(index).path);
     browser = Browser::Create(profile);
   }
   std::string page = chrome::kManageProfileSubPage;
   page += "#";
   page += base::IntToString(static_cast<int>(index));
   browser->ShowOptionsTab(page);
 }
 
 void AvatarMenuModel::AddNewProfile() {
   ProfileManager::CreateMultiProfileAsync();
   ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ADD_NEW_USER);
   ProfileMetrics::LogProfileOpenMethod(ProfileMetrics::ADD_NEW_USER_ICON);
 }
 
 size_t AvatarMenuModel::GetNumberOfItems() {
   return items_.size();
 }
 
 size_t AvatarMenuModel::GetActiveProfileIndex() {
-  // During singleton profile deletion, this function can be called with no
-  // profiles in the model - crbug.com/102278 .
-  if (items_.size() == 0)
-    return 0;
+  for (size_t i = 0; i < items_.size(); ++i) {
+    if (items_[i]->active)
+      return i;
+  }
 
-  Profile* active_profile = NULL;
-  if (!browser_)
-    active_profile = ProfileManager::GetLastUsedProfile();
-  else
-    active_profile = browser_->profile();
-
-  size_t index =
-      profile_info_->GetIndexOfProfileWithPath(active_profile->GetPath());
-
-  DCHECK_LT(index, items_.size());
-  return index;
+  // We can reach here during singleton profile deleting.
+  return 0;
 }
 
 const AvatarMenuModel::Item& AvatarMenuModel::GetItemAt(size_t index) {
   DCHECK_LT(index, items_.size());
   return *items_[index];
 }
 
 void AvatarMenuModel::Observe(int type,
                               const content::NotificationSource& source,
                               const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED, type);
   RebuildMenu();
   observer_->OnAvatarMenuModelChanged(this);
 }
 
 // static
 bool AvatarMenuModel::ShouldShowAvatarMenu() {
   return ProfileManager::IsMultipleProfilesEnabled() &&
       g_browser_process->profile_manager()->GetNumberOfProfiles() > 1;
 }
 
 void AvatarMenuModel::RebuildMenu() {
   ClearMenu();
 
-  const size_t count = profile_info_->GetNumberOfProfiles();
-  for (size_t i = 0; i < count; ++i) {
-    Item* item = new Item(i, profile_info_->GetAvatarIconOfProfileAtIndex(i));
-    item->name = profile_info_->GetNameOfProfileAtIndex(i);
-    item->sync_state = profile_info_->GetUserNameOfProfileAtIndex(i);
+  std::vector<ProfileInfoEntry> entries(
+      profile_info_->GetProfilesSortedByName());
+  for (size_t i = 0; i < entries.size(); ++i) {
+    const ProfileInfoEntry& entry = entries[i];
+    Item* item = new Item(i, entry.GetIcon());
+    item->name = entry.name();
+    item->sync_state = entry.user_name();
     if (item->sync_state.empty()) {
       item->sync_state = l10n_util::GetStringUTF16(
           IDS_PROFILES_LOCAL_PROFILE_STATE);
     }
-    if (browser_) {
-      FilePath path = profile_info_->GetPathOfProfileAtIndex(i);
-      item->active = browser_->profile()->GetPath() == path;
-    }
+    if (browser_)
+      item->active = browser_->profile()->GetPath() == entry.path();
     items_.push_back(item);
   }
 }
 
 void AvatarMenuModel::ClearMenu() {
   STLDeleteContainerPointers(items_.begin(), items_.end());
   items_.clear();
 }