Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/email_field.cc » ('j') | components/autofill/core/browser/email_field.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_metrics_unittest.cc
diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc
index d101f879395c0cfd9de4ca60d87252e3ed1a4b3f..12038f896dcfe0815211867d1a48999e07088601 100644
--- a/components/autofill/core/browser/autofill_metrics_unittest.cc
+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc
@@ -524,7 +524,7 @@ TEST_F(AutofillMetricsTest, DeveloperEngagement) {
// Ensure no metrics are logged when loading a non-fillable form.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, TimeTicks());
autofill_manager_->Reset();
histogram_tester.ExpectTotalCount("Autofill.DeveloperEngagement", 0);
}
@@ -537,7 +537,7 @@ TEST_F(AutofillMetricsTest, DeveloperEngagement) {
// author-specified field type hints.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, TimeTicks());
autofill_manager_->Reset();
histogram_tester.ExpectUniqueSample("Autofill.DeveloperEngagement",
AutofillMetrics::FILLABLE_FORM_PARSED,
@@ -563,7 +563,7 @@ TEST_F(AutofillMetricsTest, DeveloperEngagement) {
// hints metric to be logged.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, TimeTicks());
autofill_manager_->Reset();
histogram_tester.ExpectBucketCount("Autofill.DeveloperEngagement",
AutofillMetrics::FILLABLE_FORM_PARSED,
@@ -684,7 +684,7 @@ TEST_F(AutofillMetricsTest, AddressSuggestionsCount) {
TEST_F(AutofillMetricsTest, AutofillIsEnabledAtPageLoad) {
base::HistogramTester histogram_tester;
autofill_manager_->set_autofill_enabled(true);
- autofill_manager_->OnFormsSeen(std::vector<FormData>(), TimeTicks());
+ autofill_manager_->OnFormsSeen(std::vector<FormData>(), false, TimeTicks());
histogram_tester.ExpectUniqueSample("Autofill.IsEnabled.PageLoad", true, 1);
}
@@ -692,7 +692,7 @@ TEST_F(AutofillMetricsTest, AutofillIsEnabledAtPageLoad) {
TEST_F(AutofillMetricsTest, AutofillIsDisabledAtPageLoad) {
base::HistogramTester histogram_tester;
autofill_manager_->set_autofill_enabled(false);
- autofill_manager_->OnFormsSeen(std::vector<FormData>(), TimeTicks());
+ autofill_manager_->OnFormsSeen(std::vector<FormData>(), false, TimeTicks());
histogram_tester.ExpectUniqueSample("Autofill.IsEnabled.PageLoad", false, 1);
}
@@ -717,7 +717,7 @@ TEST_F(AutofillMetricsTest, UserHappinessFormLoadAndSubmission) {
// Expect no notifications when the form is first seen.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, TimeTicks());
histogram_tester.ExpectTotalCount("Autofill.UserHappiness", 0);
}
@@ -739,7 +739,7 @@ TEST_F(AutofillMetricsTest, UserHappinessFormLoadAndSubmission) {
// Expect a notification when the form is first seen.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, TimeTicks());
histogram_tester.ExpectUniqueSample("Autofill.UserHappiness",
AutofillMetrics::FORMS_LOADED, 1);
}
@@ -845,7 +845,7 @@ TEST_F(AutofillMetricsTest, UserHappinessFormInteraction) {
// Expect a notification when the form is first seen.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, TimeTicks());
histogram_tester.ExpectUniqueSample("Autofill.UserHappiness",
AutofillMetrics::FORMS_LOADED, 1);
}
@@ -970,7 +970,8 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {
// user interaction.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
+ autofill_manager_->OnFormsSeen(forms, false,
+ TimeTicks::FromInternalValue(1));
autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
histogram_tester.ExpectTotalCount(
@@ -988,7 +989,8 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {
// Expect metric to be logged if the user manually edited a form field.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
+ autofill_manager_->OnFormsSeen(forms, false,
+ TimeTicks::FromInternalValue(1));
autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
TimeTicks::FromInternalValue(3));
autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
@@ -1009,7 +1011,8 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {
form.fields[0].is_autofilled = true;
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
+ autofill_manager_->OnFormsSeen(forms, false,
+ TimeTicks::FromInternalValue(1));
autofill_manager_->OnDidFillAutofillFormData(
TimeTicks::FromInternalValue(5));
autofill_manager_->FormSubmitted(form, TimeTicks::FromInternalValue(17));
@@ -1032,7 +1035,8 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
+ autofill_manager_->OnFormsSeen(forms, false,
+ TimeTicks::FromInternalValue(1));
autofill_manager_->OnDidFillAutofillFormData(
TimeTicks::FromInternalValue(5));
autofill_manager_->OnTextFieldDidChange(form, form.fields.front(),
@@ -1055,8 +1059,9 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {
// form.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
- autofill_manager_->OnFormsSeen(second_forms,
+ autofill_manager_->OnFormsSeen(forms, false,
+ TimeTicks::FromInternalValue(1));
+ autofill_manager_->OnFormsSeen(second_forms, false,
TimeTicks::FromInternalValue(3));
autofill_manager_->OnDidFillAutofillFormData(
TimeTicks::FromInternalValue(5));
@@ -1080,8 +1085,9 @@ TEST_F(AutofillMetricsTest, FormFillDuration) {
// later loading time.
{
base::HistogramTester histogram_tester;
- autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
- autofill_manager_->OnFormsSeen(second_forms,
+ autofill_manager_->OnFormsSeen(forms, false,
+ TimeTicks::FromInternalValue(1));
+ autofill_manager_->OnFormsSeen(second_forms, false,
TimeTicks::FromInternalValue(5));
autofill_manager_->FormSubmitted(second_form,
TimeTicks::FromInternalValue(17));
« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/email_field.cc » ('j') | components/autofill/core/browser/email_field.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698