Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 853523004: Autofill: Set requirements for number of recognized fields in an autofillable form (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index 246c26d218357eaebe6abc82495b2e4b1ed2e7a9..be1359d535c39e1f5616f2f29b938f6bfac0b159 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -87,7 +87,7 @@ class TestPersonalDataManager : public PersonalDataManager {
local_credit_cards_.push_back(credit_card);
}
- virtual void RemoveByGUID(const std::string& guid) override {
+ void RemoveByGUID(const std::string& guid) override {
CreditCard* credit_card = GetCreditCardWithGUID(guid.c_str());
if (credit_card) {
local_credit_cards_.erase(
@@ -104,7 +104,7 @@ class TestPersonalDataManager : public PersonalDataManager {
// Do nothing (auxiliary profiles will be created in
// CreateTestAuxiliaryProfile).
- virtual void LoadAuxiliaryProfiles(bool record_metrics) const override {}
+ void LoadAuxiliaryProfiles(bool record_metrics) const override {}
void ClearAutofillProfiles() {
web_profiles_.clear();
@@ -645,7 +645,7 @@ class AutofillManagerTest : public testing::Test {
}
void FormsSeen(const std::vector<FormData>& forms) {
- autofill_manager_->OnFormsSeen(forms, base::TimeTicks());
+ autofill_manager_->OnFormsSeen(forms, false, base::TimeTicks());
}
void FormSubmitted(const FormData& form) {
@@ -754,7 +754,7 @@ TEST_F(AutofillManagerTest, GetProfileSuggestionsMatchCharacter) {
FormsSeen(forms);
FormFieldData field;
- test::CreateTestFormField("First Name", "firstname", "E", "text",&field);
+ test::CreateTestFormField("First Name", "firstname", "E", "text", &field);
GetAutofillSuggestions(form, field);
// No suggestions provided, so send an empty vector as the results.
@@ -777,9 +777,9 @@ TEST_F(AutofillManagerTest, GetProfileSuggestionsUnknownFields) {
form.user_submitted = true;
FormFieldData field;
- test::CreateTestFormField("Username", "username", "", "text",&field);
+ test::CreateTestFormField("Username", "username", "", "text", &field);
form.fields.push_back(field);
- test::CreateTestFormField("Password", "password", "", "password",&field);
+ test::CreateTestFormField("Password", "password", "", "password", &field);
form.fields.push_back(field);
test::CreateTestFormField("Quest", "quest", "", "quest", &field);
form.fields.push_back(field);
@@ -1326,7 +1326,6 @@ TEST_F(AutofillManagerTest, GetProfileSuggestionsFancyPhone) {
Suggestion("12345678901", "Elvis Aaron Presley", "", 1),
Suggestion("23456789012", "Charles Hardin Holley", "", 2),
Suggestion("18007724743", "Natty Bumppo", "", 3)); // 1800PRAIRIE
-
}
TEST_F(AutofillManagerTest, GetProfileSuggestionsForPhonePrefixOrSuffix) {
@@ -2772,7 +2771,7 @@ TEST_F(AutofillManagerTest, RemoveProfile) {
EXPECT_FALSE(autofill_manager_->GetProfileWithGUID(guid.c_str()));
}
-TEST_F(AutofillManagerTest, RemoveCreditCard){
+TEST_F(AutofillManagerTest, RemoveCreditCard) {
// Add and remove an Autofill credit card.
CreditCard* credit_card = new CreditCard;
std::string guid = "00000000-0000-0000-0000-000000100007";

Powered by Google App Engine
This is Rietveld 408576698