Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 853493003: Correctly reference global proxy in the partial snapshot. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly reference global proxy in the partial snapshot. R=verwaest@chromium.org Committed: https://crrev.com/fe82e03bb6f1229ebb9d1959a81835a4405a9321 Cr-Commit-Position: refs/heads/master@{#26061}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Patch Set 3 : remove bogus check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -69 lines) Patch
M src/bootstrapper.cc View 8 chunks +28 lines, -29 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/factory.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/serialize.h View 1 9 chunks +19 lines, -13 lines 0 comments Download
M src/serialize.cc View 8 chunks +24 lines, -16 lines 0 comments Download
M src/snapshot.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot-common.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 6 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Yang
5 years, 11 months ago (2015-01-14 13:08:11 UTC) #1
Toon Verwaest
lgtm with nits https://codereview.chromium.org/853493003/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/853493003/diff/1/src/factory.cc#newcode1965 src/factory.cc:1965: FAST_HOLEY_SMI_ELEMENTS); Omit the last argument to ...
5 years, 11 months ago (2015-01-14 14:16:28 UTC) #2
Yang
Addressed comments.
5 years, 11 months ago (2015-01-14 14:31:14 UTC) #3
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-14 14:40:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853493003/20001
5 years, 11 months ago (2015-01-14 14:45:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/2117)
5 years, 11 months ago (2015-01-14 15:30:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853493003/40001
5 years, 11 months ago (2015-01-14 15:59:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 16:42:22 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:42:38 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe82e03bb6f1229ebb9d1959a81835a4405a9321
Cr-Commit-Position: refs/heads/master@{#26061}

Powered by Google App Engine
This is Rietveld 408576698