src/objects-debug.cc - Issue 853493003: Correctly reference global proxy in the partial snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 853493003: Correctly reference global proxy in the partial snapshot. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: remove bogus check Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index 83a6833f03aa242690f7f416cf510e48cba0c92f..9c03dcc2eacb4cd93b782e9520a99740fabbcf12 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -567,7 +567,6 @@ void JSGlobalProxy::JSGlobalProxyVerify() {

VerifyObjectField(JSGlobalProxy::kNativeContextOffset);

// Make sure that this object has no properties, elements.

CHECK_EQ(0, properties()->length());

- CHECK_EQ(FAST_HOLEY_SMI_ELEMENTS, GetElementsKind());

CHECK_EQ(0, FixedArray::cast(elements())->length());

}

« no previous file with comments | « src/factory.cc ('k') | src/serialize.h » ('j') | no next file with comments »