Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 853393002: cc: refactor of MathUtil::AddToTracedValue (Closed)

Created:
5 years, 11 months ago by JungJik
Modified:
5 years, 11 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: refactor of MathUtil::AddToTracedValue Pass the name to MathUtilAddToTracedValue and decide the json value type internally. so that we could add the value without knowing the value type. Committed: https://crrev.com/50f9c8e35e788b657d3b3cd825ece454a13ffc63 Cr-Commit-Position: refs/heads/master@{#312339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -148 lines) Patch
M cc/base/math_util.h View 1 chunk +24 lines, -12 lines 0 comments Download
M cc/base/math_util.cc View 2 chunks +48 lines, -12 lines 0 comments Download
M cc/layers/layer_impl.cc View 2 chunks +7 lines, -21 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M cc/layers/tiled_layer_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/output/filter_operation.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/quads/content_draw_quad_base.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M cc/quads/draw_quad.cc View 2 chunks +9 lines, -18 lines 0 comments Download
M cc/quads/io_surface_draw_quad.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/quads/picture_draw_quad.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/quads/render_pass.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M cc/quads/render_pass_draw_quad.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M cc/quads/shared_quad_state.cc View 1 chunk +5 lines, -14 lines 0 comments Download
M cc/quads/stream_video_draw_quad.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/quads/texture_draw_quad.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/resources/picture.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/resources/tile.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
JungJik
PTAL.
5 years, 11 months ago (2015-01-19 05:54:57 UTC) #2
vmpstr
lgtm, thanks!
5 years, 11 months ago (2015-01-20 17:42:58 UTC) #4
danakj
LGTM
5 years, 11 months ago (2015-01-20 20:02:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853393002/1
5 years, 11 months ago (2015-01-21 02:13:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 14:06:46 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:08:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50f9c8e35e788b657d3b3cd825ece454a13ffc63
Cr-Commit-Position: refs/heads/master@{#312339}

Powered by Google App Engine
This is Rietveld 408576698