cc/output/filter_operation.cc - Issue 853393002: cc: refactor of MathUtil::AddToTracedValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/filter_operation.cc

Issue 853393002: cc: refactor of MathUtil::AddToTracedValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/filter_operation.cc

diff --git a/cc/output/filter_operation.cc b/cc/output/filter_operation.cc

index 173985b384a7b62066af5d3c92f979d7375589e4..b4a84bde51bea058431689cd0117e4e6a553f436 100644

--- a/cc/output/filter_operation.cc

+++ b/cc/output/filter_operation.cc

@@ -272,9 +272,7 @@ void FilterOperation::AsValueInto(base::debug::TracedValue* value) const {

break;

case FilterOperation::DROP_SHADOW:

value->SetDouble("std_deviation", amount_);

- value->BeginArray("offset");

- MathUtil::AddToTracedValue(drop_shadow_offset_, value);

- value->EndArray();

+ MathUtil::AddToTracedValue("offset", drop_shadow_offset_, value);

value->SetInteger("color", drop_shadow_color_);

break;

case FilterOperation::COLOR_MATRIX: {

« no previous file with comments | « cc/layers/tiled_layer_impl.cc ('k') | cc/quads/content_draw_quad_base.cc » ('j') | no next file with comments »