PRESUBMIT.py - Issue 853073003: Fix assertion starting cast_shell (breaking thread IO restrictions).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 853073003: Fix assertion starting cast_shell (breaking thread IO restrictions). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mistake in presubmit regex Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 9bc1f0fda0f91acabfc85c755a2d61ca669ce16f..ea018f9f75e7f7cc3449b1b5f81e2325568f685a 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -174,6 +174,7 @@ _BANNED_CPP_FUNCTIONS = (

r"simple_platform_shared_buffer_posix\.cc$",

r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",

r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",

+ r"^ui[\\\/]events[\\\/]ozone[\\\/]device[\\\/]device_manager_manual\.cc$",

spang 2015/01/16 01:20:29 Doh! Didn't realize this presubmit exited. We prob

(

« no previous file with comments | « no previous file | ui/events/ozone/device/device_manager_manual.cc » ('j') | no next file with comments »