Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: PRESUBMIT.py

Issue 853073003: Fix assertion starting cast_shell (breaking thread IO restrictions). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Mistake in presubmit regex Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/events/ozone/device/device_manager_manual.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$", 167 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]boot_times_recorder\.cc$",
168 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]" 168 r"^chrome[\\\/]browser[\\\/]chromeos[\\\/]"
169 "customization_document_browsertest\.cc$", 169 "customization_document_browsertest\.cc$",
170 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$", 170 r"^components[\\\/]crash[\\\/]app[\\\/]breakpad_mac\.mm$",
171 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$", 171 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_browser_main\.cc$",
172 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$", 172 r"^content[\\\/]shell[\\\/]browser[\\\/]shell_message_filter\.cc$",
173 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" + 173 r"^mojo[\\\/]edk[\\\/]embedder[\\\/]" +
174 r"simple_platform_shared_buffer_posix\.cc$", 174 r"simple_platform_shared_buffer_posix\.cc$",
175 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$", 175 r"^net[\\\/]disk_cache[\\\/]cache_util\.cc$",
176 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$", 176 r"^net[\\\/]url_request[\\\/]test_url_fetcher_factory\.cc$",
177 r"^ui[\\\/]events[\\\/]ozone[\\\/]device[\\\/]device_manager_manual\.cc$ ",
spang 2015/01/16 01:20:29 Doh! Didn't realize this presubmit exited. We prob
177 ), 178 ),
178 ), 179 ),
179 ( 180 (
180 'SkRefPtr', 181 'SkRefPtr',
181 ( 182 (
182 'The use of SkRefPtr is prohibited. ', 183 'The use of SkRefPtr is prohibited. ',
183 'Please use skia::RefPtr instead.' 184 'Please use skia::RefPtr instead.'
184 ), 185 ),
185 True, 186 True,
186 (), 187 (),
(...skipping 1505 matching lines...) Expand 10 before | Expand all | Expand 10 after
1692 if 'presubmit' in builder: 1693 if 'presubmit' in builder:
1693 builders[master].pop(builder) 1694 builders[master].pop(builder)
1694 1695
1695 # Match things like path/aura/file.cc and path/file_aura.cc. 1696 # Match things like path/aura/file.cc and path/file_aura.cc.
1696 # Same for chromeos. 1697 # Same for chromeos.
1697 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files): 1698 if any(re.search(r'[\\\/_](aura|chromeos)', f) for f in files):
1698 tryserver_linux = builders.setdefault('tryserver.chromium.linux', {}) 1699 tryserver_linux = builders.setdefault('tryserver.chromium.linux', {})
1699 tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests'] 1700 tryserver_linux['linux_chromium_chromeos_asan_rel_ng'] = ['defaulttests']
1700 1701
1701 return builders 1702 return builders
OLDNEW
« no previous file with comments | « no previous file | ui/events/ozone/device/device_manager_manual.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698