Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 853013002: Disable Goma for the OS X builders on chromium.swarm (Closed)

Created:
5 years, 11 months ago by Sébastien Marchand
Modified:
5 years, 11 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Disable Goma for the OS X builders on chromium.swarm. Temporary patch to check how much of the indeterminism is caused by Goma. BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293654

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M scripts/slave/recipes/swarming/deterministic_build.py View 1 chunk +3 lines, -1 line 2 comments Download
M scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_build.json View 3 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sébastien Marchand
PTAL.
5 years, 11 months ago (2015-01-15 18:47:15 UTC) #2
M-A Ruel
https://codereview.chromium.org/853013002/diff/1/scripts/slave/recipes/swarming/deterministic_build.py File scripts/slave/recipes/swarming/deterministic_build.py (right): https://codereview.chromium.org/853013002/diff/1/scripts/slave/recipes/swarming/deterministic_build.py#newcode51 scripts/slave/recipes/swarming/deterministic_build.py:51: 'chromium_config': 'chromium_no_goma', should we reenable it now on linux ...
5 years, 11 months ago (2015-01-15 18:49:00 UTC) #3
M-A Ruel
lgtm anyhow
5 years, 11 months ago (2015-01-15 18:49:10 UTC) #4
Sébastien Marchand
Thanks, committing. https://codereview.chromium.org/853013002/diff/1/scripts/slave/recipes/swarming/deterministic_build.py File scripts/slave/recipes/swarming/deterministic_build.py (right): https://codereview.chromium.org/853013002/diff/1/scripts/slave/recipes/swarming/deterministic_build.py#newcode51 scripts/slave/recipes/swarming/deterministic_build.py:51: 'chromium_config': 'chromium_no_goma', On 2015/01/15 18:49:00, M-A Ruel ...
5 years, 11 months ago (2015-01-15 19:12:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/853013002/1
5 years, 11 months ago (2015-01-15 19:13:57 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 19:16:30 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293654

Powered by Google App Engine
This is Rietveld 408576698