scripts/slave/recipes/swarming/deterministic_build.py - Issue 853013002: Disable Goma for the OS X builders on chromium.swarm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/swarming/deterministic_build.py

Issue 853013002: Disable Goma for the OS X builders on chromium.swarm (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Mac_deterministic_build.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/swarming/deterministic_build.py

diff --git a/scripts/slave/recipes/swarming/deterministic_build.py b/scripts/slave/recipes/swarming/deterministic_build.py

index 3052fd806af17cf38b83dd670e2cd9aae472b941..997c7eed71a7b6496209c38932d09841b6eee943 100644

--- a/scripts/slave/recipes/swarming/deterministic_build.py

+++ b/scripts/slave/recipes/swarming/deterministic_build.py

@@ -53,7 +53,9 @@ DETERMINISTIC_BUILDERS = {

'platform': 'linux',

'Mac deterministic build': {

- 'chromium_config': 'chromium',

+ # TODO(sebmarchand): Reactivate goma once the indeterminism coming from

+ # it has been fixed.

+ 'chromium_config': 'chromium_no_goma',

'gclient_config': 'chromium',

'platform': 'mac',