Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9006)

Unified Diff: chrome/browser/views/infobars/translate_infobars.cc

Issue 853010: Adding UMA stats to the translate UI so we can get user usage... (Closed) Base URL: svn://chrome-svn/chrome/branches/249/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_infobars_delegates.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/infobars/translate_infobars.cc
===================================================================
--- chrome/browser/views/infobars/translate_infobars.cc (revision 41336)
+++ chrome/browser/views/infobars/translate_infobars.cc (working copy)
@@ -253,6 +253,9 @@
// Register for PAGE_TRANSLATED notification.
notification_registrar_.Add(this, NotificationType::PAGE_TRANSLATED,
Source<TabContents>(GetDelegate()->tab_contents()));
+
+ if (GetDelegate()->state() == TranslateInfoBarDelegate::kBeforeTranslate)
+ UMA_HISTOGRAM_COUNTS("Translate.ShowBeforeTranslateInfobar", 1);
}
TranslateInfoBar::~TranslateInfoBar() {
@@ -548,22 +551,27 @@
void TranslateInfoBar::ExecuteCommand(int command_id) {
if (command_id >= IDC_TRANSLATE_TARGET_LANGUAGE_BASE) {
+ UMA_HISTOGRAM_COUNTS("Translate.ModifyTargetLang", 1);
OnLanguageModified(target_language_menu_button_,
command_id - IDC_TRANSLATE_TARGET_LANGUAGE_BASE);
} else if (command_id >= IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE) {
+ UMA_HISTOGRAM_COUNTS("Translate.ModifyOriginalLang", 1);
OnLanguageModified(original_language_menu_button_,
command_id - IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE);
} else {
switch (command_id) {
case IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_LANG:
+ UMA_HISTOGRAM_COUNTS("Translate.NeverTranslateLang", 1);
GetDelegate()->ToggleLanguageBlacklist();
break;
case IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_SITE:
+ UMA_HISTOGRAM_COUNTS("Translate.NeverTranslateSite", 1);
GetDelegate()->ToggleSiteBlacklist();
break;
case IDC_TRANSLATE_OPTIONS_ALWAYS:
+ UMA_HISTOGRAM_COUNTS("Translate.AlwaysTranslateLang", 1);
GetDelegate()->ToggleAlwaysTranslate();
break;
@@ -592,8 +600,10 @@
if (sender == accept_button_) {
GetDelegate()->Translate();
UpdateState(GetDelegate()->state());
+ UMA_HISTOGRAM_COUNTS("Translate.Translate", 1);
} else if (sender == deny_button_) {
GetDelegate()->TranslationDeclined();
+ UMA_HISTOGRAM_COUNTS("Translate.DeclineTranslate", 1);
RemoveInfoBar();
} else { // Let base InfoBar handle close button.
InfoBar::ButtonPressed(sender, event);
« no previous file with comments | « chrome/browser/translate/translate_infobars_delegates.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698