Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 853010: Adding UMA stats to the translate UI so we can get user usage... (Closed)

Created:
10 years, 9 months ago by jcampan
Modified:
9 years, 7 months ago
Reviewers:
kuan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Adding UMA stats to the translate UI so we can get user usage and understand and improve the translate feature. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41514

Patch Set 1 #

Total comments: 16

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/translate/translate_infobars_delegates.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/infobars/translate_infobars.cc View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jcampan
10 years, 9 months ago (2010-03-13 00:29:32 UTC) #1
kuan
my suggestion was to move all uma calls to delegate, which shld mk the code ...
10 years, 9 months ago (2010-03-13 00:47:31 UTC) #2
jcampan
http://codereview.chromium.org/853010/diff/1/2 File chrome/browser/views/infobars/translate_infobars.cc (right): http://codereview.chromium.org/853010/diff/1/2#newcode551 chrome/browser/views/infobars/translate_infobars.cc:551: UMA_HISTOGRAM_COUNTS("Translate.ModifyTargetLang", 1); On 2010/03/13 00:47:31, kuan wrote: > maybe ...
10 years, 9 months ago (2010-03-13 00:58:48 UTC) #3
kuan
10 years, 9 months ago (2010-03-13 01:01:26 UTC) #4
LGTM.

On 2010/03/13 00:58:48, jcampan wrote:
> http://codereview.chromium.org/853010/diff/1/2
> File chrome/browser/views/infobars/translate_infobars.cc (right):
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode551
> chrome/browser/views/infobars/translate_infobars.cc:551:
> UMA_HISTOGRAM_COUNTS("Translate.ModifyTargetLang", 1);
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe call this in TranslateInfoBarDelegate::ModifyTargetLang.
> The goal of these UMA stats is to provide us with information about what users
> do. I am afraid that by moving things to the delegate, we might report calls
> made by APIs and not user.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode555
> chrome/browser/views/infobars/translate_infobars.cc:555:
> UMA_HISTOGRAM_COUNTS("Translate.ModifyOriginalLang", 1);
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe call this in TranslateInfoBarDelegate::ModifyOriginalLang.
> 
> Same remark as above.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode562
> chrome/browser/views/infobars/translate_infobars.cc:562:
> GetDelegate()->ToggleLanguageBlacklist();
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe move the uma call to delegate's ToggleLanguageBlacklist.
> 
> Same remark as above.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode567
> chrome/browser/views/infobars/translate_infobars.cc:567:
> GetDelegate()->ToggleSiteBlacklist();
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe move the uma call to delegate's ToggleSiteBlacklist.
> 
> Same remark as above.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode572
> chrome/browser/views/infobars/translate_infobars.cc:572:
> GetDelegate()->ToggleAlwaysTranslate();
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe move the uma call to delegate's ToggleAlwaysTranslate.
> 
> Same remark as above.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode600
> chrome/browser/views/infobars/translate_infobars.cc:600:
> UMA_HISTOGRAM_COUNTS("Translate.Translate", 1);
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe move the uma call to delegate's Translate.
> 
> If we do that, we won't know if it is an automatic translation or a user
> initiated one.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode603
> chrome/browser/views/infobars/translate_infobars.cc:603:
> UMA_HISTOGRAM_COUNTS("Translate.DeclineTranslate", 1);
> On 2010/03/13 00:47:31, kuan wrote:
> > maybe move the uma call to TranslationDeclined.
> 
> If we do that we won't be able to differentiate when the user declines by
> clicking the "Nope" button or closing the info-bar.
> 
> http://codereview.chromium.org/853010/diff/1/2#newcode738
> chrome/browser/views/infobars/translate_infobars.cc:738:
> GetDelegate()->Translate();
> On 2010/03/13 00:47:31, kuan wrote:
> > if u move the uma call for Translate above to delegate, then this is ok,
> > otherwise, u need to call uma for Translate here.
> I think it is OK. We want to track user usage. So Translate in UMA stats means
> user clicked the translate button. Here the stat about user changing the
target
> language is indication already.

Powered by Google App Engine
This is Rietveld 408576698