Adding UMA stats to the translate UI so we can get user usage...

chrome/browser/views/infobars/translate_infobars.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/infobars/translate_infobars.h"
 
 #include "app/gfx/canvas.h"
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/utf_string_conversions.h"
@@ skipping 530 matching lines @@
   return true;
 }
 
 bool TranslateInfoBar::GetAcceleratorForCommandId(int command_id,
     views::Accelerator* accelerator) {
   return false;
 }
 
 void TranslateInfoBar::ExecuteCommand(int command_id) {
   if (command_id >= IDC_TRANSLATE_TARGET_LANGUAGE_BASE) {
+    UMA_HISTOGRAM_COUNTS("Translate.ModifyTargetLang", 1);

[kuan, 2010/03/13 00:47:31]

maybe call this in TranslateInfoBarDelegate::ModifyTargetLang.

[jcampan, 2010/03/13 00:58:48]

The goal of these UMA stats is to provide us with information about what users
do. I am afraid that by moving things to the delegate, we might report calls
made by APIs and not user.

     OnLanguageModified(target_language_menu_button_,
         command_id - IDC_TRANSLATE_TARGET_LANGUAGE_BASE);
   } else if (command_id >= IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE) {
+    UMA_HISTOGRAM_COUNTS("Translate.ModifyOriginalLang", 1);

[kuan, 2010/03/13 00:47:31]

maybe call this in TranslateInfoBarDelegate::ModifyOriginalLang.

[jcampan, 2010/03/13 00:58:48]

Same remark as above.

     OnLanguageModified(original_language_menu_button_,
         command_id - IDC_TRANSLATE_ORIGINAL_LANGUAGE_BASE);
   } else {
     switch (command_id) {
       case IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_LANG:
+        UMA_HISTOGRAM_COUNTS("Translate.NeverTranslateLang", 1);
         GetDelegate()->ToggleLanguageBlacklist();

[kuan, 2010/03/13 00:47:31]

maybe move the uma call to delegate's ToggleLanguageBlacklist.

[jcampan, 2010/03/13 00:58:48]

Same remark as above.

         break;
 
       case IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_SITE:
+        UMA_HISTOGRAM_COUNTS("Translate.NeverTranslateSite", 1);
         GetDelegate()->ToggleSiteBlacklist();

[kuan, 2010/03/13 00:47:31]

maybe move the uma call to delegate's ToggleSiteBlacklist.

[jcampan, 2010/03/13 00:58:48]

Same remark as above.

         break;
 
       case IDC_TRANSLATE_OPTIONS_ALWAYS:
+        UMA_HISTOGRAM_COUNTS("Translate.AlwaysTranslateLang", 1);
         GetDelegate()->ToggleAlwaysTranslate();

[kuan, 2010/03/13 00:47:31]

maybe move the uma call to delegate's ToggleAlwaysTranslate.

[jcampan, 2010/03/13 00:58:48]

Same remark as above.

         break;
 
       case IDC_TRANSLATE_OPTIONS_ABOUT: {
         TabContents* tab_contents = GetDelegate()->tab_contents();
         if (tab_contents) {
           string16 url = l10n_util::GetStringUTF16(
               IDS_ABOUT_GOOGLE_TRANSLATE_URL);
           tab_contents->OpenURL(GURL(url), GURL(), NEW_FOREGROUND_TAB,
               PageTransition::LINK);
         }
         break;
       }
 
       default:
         NOTREACHED() << "Invalid command id from menu.";
         break;
     }
   }
 }
 
 // TranslateInfoBar, views::ButtonListener overrides: --------------------------
 
 void TranslateInfoBar::ButtonPressed(
     views::Button* sender, const views::Event& event) {
   if (sender == accept_button_) {
     GetDelegate()->Translate();
     UpdateState(GetDelegate()->state());
+    UMA_HISTOGRAM_COUNTS("Translate.Translate", 1);

[kuan, 2010/03/13 00:47:31]

maybe move the uma call to delegate's Translate.

[jcampan, 2010/03/13 00:58:48]

If we do that, we won't know if it is an automatic translation or a user
initiated one.

   } else if (sender == deny_button_) {
     GetDelegate()->TranslationDeclined();
+    UMA_HISTOGRAM_COUNTS("Translate.DeclineTranslate", 1);

[kuan, 2010/03/13 00:47:31]

maybe move the uma call to TranslationDeclined.

[jcampan, 2010/03/13 00:58:48]

If we do that we won't be able to differentiate when the user declines by
clicking the "Nope" button or closing the info-bar.

     RemoveInfoBar();
   } else {  // Let base InfoBar handle close button.
     InfoBar::ButtonPressed(sender, event);
   }
 }
 
 // TranslateInfoBar, NotificationObserver overrides: ---------------------------
 
 void TranslateInfoBar::Observe(NotificationType type,
     const NotificationSource& source, const NotificationDetails& details) {
@@ skipping 114 matching lines @@
       GetDelegate()->GetLocaleFromIndex(new_language_index));
   menu_button->SetText(UTF16ToWideHack(new_language));
   menu_button->ClearMaxTextSize();
   menu_button->SizeToPreferredSize();
   Layout();
   SchedulePaint();
   // Clear options menu model so that it'll be created with new language.
   options_menu_model_.reset();
   // If necessary, trigger translation.
   if (GetDelegate()->state() == TranslateInfoBarDelegate::kAfterTranslate)
     GetDelegate()->Translate();

[kuan, 2010/03/13 00:47:31]

if u move the uma call for Translate above to delegate, then this is ok,
otherwise, u need to call uma for Translate here.

[jcampan, 2010/03/13 00:58:48]

I think it is OK. We want to track user usage. So Translate in UMA stats means
user clicked the translate button. Here the stat about user changing the target
language is indication already.

 }
 
 inline TranslateInfoBarDelegate* TranslateInfoBar::GetDelegate() const {
   return static_cast<TranslateInfoBarDelegate*>(delegate());
 }
 
 inline int TranslateInfoBar::GetSpacingAfterFirstLanguageButton() const {
   return (GetDelegate()->state() == TranslateInfoBarDelegate::kBeforeTranslate ?
       10 : kButtonInLabelSpacing);
 }
 
 // TranslateInfoBarDelegate, InfoBarDelegate overrides: ------------------
 
 InfoBar* TranslateInfoBarDelegate::CreateInfoBar() {
   return new TranslateInfoBar(this);
 }