Source/modules/webmidi/MIDIAccessPromise.h - Issue 85263006: Make IDL Callbacks non-refcounted by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccessPromise.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webmidi/MIDIAccessPromise.h

diff --git a/Source/modules/webmidi/MIDIAccessPromise.h b/Source/modules/webmidi/MIDIAccessPromise.h

index d21b96e41f2cb9f205cfc99b11916b8fa56a49c0..074273c74cd0e2acfb7f6c027b47834e9719dc97 100644

--- a/Source/modules/webmidi/MIDIAccessPromise.h

+++ b/Source/modules/webmidi/MIDIAccessPromise.h

@@ -62,7 +62,7 @@ public:

void fulfill();

void reject(PassRefPtr<DOMError>);

- void then(PassRefPtr<MIDISuccessCallback>, PassRefPtr<MIDIErrorCallback>);

+ void then(PassOwnPtr<MIDISuccessCallback>, PassOwnPtr<MIDIErrorCallback>);

private:

enum State {

@@ -77,8 +77,8 @@ private:

void clear();

State m_state;

- RefPtr<MIDISuccessCallback> m_successCallback;

- RefPtr<MIDIErrorCallback> m_errorCallback;

+ OwnPtr<MIDISuccessCallback> m_successCallback;

+ OwnPtr<MIDIErrorCallback> m_errorCallback;

OwnPtr<MIDIOptions> m_options;

RefPtr<DOMError> m_error;

RefPtr<MIDIAccess> m_access;