Source/modules/webmidi/MIDIAccessPromise.cpp - Issue 85263006: Make IDL Callbacks non-refcounted by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccessPromise.cpp

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webmidi/MIDIAccessPromise.cpp

diff --git a/Source/modules/webmidi/MIDIAccessPromise.cpp b/Source/modules/webmidi/MIDIAccessPromise.cpp

index 01a6dfa299860bf2ea09a83ed74cdfd04c20b8e3..7ae06b3faae097ec6871a56218d3dd72b0bcb675 100644

--- a/Source/modules/webmidi/MIDIAccessPromise.cpp

+++ b/Source/modules/webmidi/MIDIAccessPromise.cpp

@@ -99,7 +99,7 @@ void MIDIAccessPromise::reject(PassRefPtr<DOMError> error)

}

-void MIDIAccessPromise::then(PassRefPtr<MIDISuccessCallback> successCallback, PassRefPtr<MIDIErrorCallback> errorCallback)

+void MIDIAccessPromise::then(PassOwnPtr<MIDISuccessCallback> successCallback, PassOwnPtr<MIDIErrorCallback> errorCallback)

{

// Lazily request access.

if (!m_access)