Source/modules/notifications/NotificationClient.h - Issue 85263006: Make IDL Callbacks non-refcounted by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/NotificationClient.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/notifications/NotificationClient.h

diff --git a/Source/modules/notifications/NotificationClient.h b/Source/modules/notifications/NotificationClient.h

index 52df610fd9440f48b00df3533b3f176518c6384a..92c946df00483ab3a5c9f3ce3e9563004b045d21 100644

--- a/Source/modules/notifications/NotificationClient.h

+++ b/Source/modules/notifications/NotificationClient.h

@@ -77,7 +77,7 @@ public:

// made a decision.

virtual void requestPermission(ExecutionContext*, PassRefPtr<VoidCallback>) = 0;

#endif

- virtual void requestPermission(ExecutionContext*, PassRefPtr<NotificationPermissionCallback>) = 0;

+ virtual void requestPermission(ExecutionContext*, PassOwnPtr<NotificationPermissionCallback>) = 0;

// Cancel all outstanding requests for the ExecutionContext

virtual void cancelRequestsForPermission(ExecutionContext*) = 0;