Source/modules/notifications/Notification.cpp - Issue 85263006: Make IDL Callbacks non-refcounted by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.cpp

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/notifications/Notification.cpp

diff --git a/Source/modules/notifications/Notification.cpp b/Source/modules/notifications/Notification.cpp

index 5d351b5aceb9f96a7a57540434c497c7557537e1..13469a0989dd065a43bb8108931ef18351381e63 100644

--- a/Source/modules/notifications/Notification.cpp

+++ b/Source/modules/notifications/Notification.cpp

@@ -248,7 +248,7 @@ const String& Notification::permissionString(NotificationClient::Permission perm

return deniedPermission;

}

-void Notification::requestPermission(ExecutionContext* context, PassRefPtr<NotificationPermissionCallback> callback)

+void Notification::requestPermission(ExecutionContext* context, PassOwnPtr<NotificationPermissionCallback> callback)

{

ASSERT(toDocument(context)->page());

NotificationController::from(toDocument(context)->page())->client()->requestPermission(context, callback);