Allow overriding GoogleLocationSettingsHelper for tests.

Allow overriding GoogleLocationSettingsHelper for tests.

Previously, GoogleLocationSettingsHelper could be "overridden" only by
compiling in a different implementation of the static method
GoogleLocationSettingsHelper::Create(). This complicates the build
targets (since the default implementation of Create() can't be defined
in shared code, since test code needs a different implementation), and
complicates the process of upstreaming the internal implementation of
GoogleLocationSettingsHelper.

This CL keeps the static method, but adds a new method for overriding
the GoogleLocationSettingsHelper:
GeolocationPermissionContextAndroid::SetGoogleLocationSettingsHelperForTests().
In a later CL, the static method will be removed.

BUG=448400
Committed: https://crrev.com/ad75c73e7b29abf6f3e06ba71ea6a63140e430e6
Cr-Commit-Position: refs/heads/master@{#311317}

[newt (away), 2015-01-13 16:26:05]

newt@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[newt (away), 2015-01-13 16:26:06]

PTAL

[Michael van Ouwerkerk, 2015-01-13 16:33:48]

https://codereview.chromium.org/852593002/diff/1/chrome/browser/android/mock_...
File chrome/browser/android/mock_google_location_settings_helper.h (right):

https://codereview.chromium.org/852593002/diff/1/chrome/browser/android/mock_...
chrome/browser/android/mock_google_location_settings_helper.h:14: virtual
~MockGoogleLocationSettingsHelper();
Nit: use override rather than virtual.

https://codereview.chromium.org/852593002/diff/1/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_permission_context_android.h
(right):

https://codereview.chromium.org/852593002/diff/1/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_permission_context_android.h:85: void
SetGoogleLocationSettingsHelperForTest(
Nit: ForTesting  - http://www.chromium.org/developers/coding-style#Naming

https://codereview.chromium.org/852593002/diff/1/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_permission_context_android.h:86:
scoped_ptr<GoogleLocationSettingsHelper>& helper);
scoped_ptr should not be a reference -
http://www.chromium.org/developers/smart-pointer-guidelines

[newt (away), 2015-01-13 16:55:04]

https://codereview.chromium.org/852593002/diff/1/chrome/browser/android/mock_...
File chrome/browser/android/mock_google_location_settings_helper.h (right):

https://codereview.chromium.org/852593002/diff/1/chrome/browser/android/mock_...
chrome/browser/android/mock_google_location_settings_helper.h:14: virtual
~MockGoogleLocationSettingsHelper();
On 2015/01/13 16:33:47, Michael van Ouwerkerk wrote:
> Nit: use override rather than virtual.

Done.

https://codereview.chromium.org/852593002/diff/1/chrome/browser/geolocation/g...
File chrome/browser/geolocation/geolocation_permission_context_android.h
(right):

https://codereview.chromium.org/852593002/diff/1/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_permission_context_android.h:85: void
SetGoogleLocationSettingsHelperForTest(
On 2015/01/13 16:33:48, Michael van Ouwerkerk wrote:
> Nit: ForTesting  - http://www.chromium.org/developers/coding-style#Naming

Done.

https://codereview.chromium.org/852593002/diff/1/chrome/browser/geolocation/g...
chrome/browser/geolocation/geolocation_permission_context_android.h:86:
scoped_ptr<GoogleLocationSettingsHelper>& helper);
On 2015/01/13 16:33:47, Michael van Ouwerkerk wrote:
> scoped_ptr should not be a reference -
> http://www.chromium.org/developers/smart-pointer-guidelines

Done.

[Michael van Ouwerkerk, 2015-01-13 17:00:55]

lgtm

[newt (away), 2015-01-13 17:03:04]

newt@chromium.org changed reviewers:
+ dtrainor@chromium.org

[newt (away), 2015-01-13 17:03:04]

+dtrainor for chrome/browser/android OWNERS

[newt (away), 2015-01-13 17:03:15]

Thanks, Michael!

[David Trainor- moved to gerrit, 2015-01-13 18:37:12]

chrome/browser/android lgtm

[newt (away), 2015-01-13 18:38:59]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-13 18:39:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852593002/20001

[commit-bot: I haz the power, 2015-01-13 20:22:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-13 20:22:57]

Patchset 2 (id:??) landed as
https://crrev.com/ad75c73e7b29abf6f3e06ba71ea6a63140e430e6
Cr-Commit-Position: refs/heads/master@{#311317}