chrome/browser/geolocation/geolocation_permission_context_android.cc - Issue 852593002: Allow overriding GoogleLocationSettingsHelper for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_android.cc

Issue 852593002: Allow overriding GoogleLocationSettingsHelper for tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/geolocation_permission_context_android.h ('k') | chrome/browser/geolocation/geolocation_permission_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_android.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_android.cc b/chrome/browser/geolocation/geolocation_permission_context_android.cc

index c5eac4e23deae01af383bddcb24ae3a6ad9690c3..f02c841cabb6ae6228c91f82ee0d5558dcd8d1be 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_android.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_android.cc

@@ -98,3 +98,9 @@ void GeolocationPermissionContextAndroid::InterceptPermissionCheck(

const BrowserPermissionCallback& callback, bool granted) {

callback.Run(granted);

}

+void GeolocationPermissionContextAndroid::

+ SetGoogleLocationSettingsHelperForTesting(

+ scoped_ptr<GoogleLocationSettingsHelper> helper) {

+ google_location_settings_helper_ = helper.Pass();