Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 852493002: Fix include paths for pdfium_unittests under chromium checkout. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix include paths for pdfium_unittests under chromium checkout. Here, testing/gtest and testing/some-pdfium-stuff will be different directories, since we will use the gtest at top-level. For standalone, they happen to be the same. TBR=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/04ddadebc55ac0e6596a1b54c0d38f828c6162a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417HighLevelEncoder_unittest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
5 years, 11 months ago (2015-01-12 22:51:51 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as 04ddadebc55ac0e6596a1b54c0d38f828c6162a4 (presubmit successful).
5 years, 11 months ago (2015-01-12 22:52:40 UTC) #3
Bo Xu
5 years, 11 months ago (2015-01-12 22:59:29 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698