Keep track of ServiceWorkerContext's BrowserContext and expose it.

content/browser/service_worker/service_worker_context_wrapper.h

Index: content/browser/service_worker/service_worker_context_wrapper.h
diff --git a/content/browser/service_worker/service_worker_context_wrapper.h b/content/browser/service_worker/service_worker_context_wrapper.h
index 56367eee1cebbe645a0e4dc537f57aa68eec1d45..af1ebb200fb506a7844e04bd0998ed8250623517 100644
--- a/content/browser/service_worker/service_worker_context_wrapper.h
+++ b/content/browser/service_worker/service_worker_context_wrapper.h
@@ -88,6 +88,7 @@ class CONTENT_EXPORT ServiceWorkerContextWrapper
   void RemoveObserver(ServiceWorkerContextObserver* observer);
 
   bool is_incognito() const { return is_incognito_; }
+  BrowserContext* browser_context() const { return browser_context_; }

[michaeln, 2015/01/12 20:19:13]

Ah... I see why you're wanting to add this, to traverse back up the UI thread
object containment hierarchy,
wrapper->(partition->partitionmap)->browsercontext, for window opening purposes
that need the browsercontext.

The need to do that makes sense but how it's currently done in the CL doesn't
(for reasons stated in other comments).

I'd vote for something like this...

1. The wrapper has a StoragePartition* ptr and a getter. The getter DCHECKS it's
only called on the UI thread. The storeage_partition_ data member is cleared in
the Shutdown() method.

2. The StoragePartition class has a virtual getter for it's BrowserContext which
may return null during shutdown. The ptr is cleared in ~StoragePartitionImpl
prior to calling the various Shutdown() methods.

I think lets you traverse up to the browsercontext safely.

wdyt?

 
   // The URLRequestContext doesn't exist until after the StoragePartition is
   // made (which is after this object is made). This function must be called
@@ -130,6 +131,9 @@ class CONTENT_EXPORT ServiceWorkerContextWrapper
 
   // Initialized in Init(); true if the user data directory is empty.
   bool is_incognito_;
+
+  // BrowserContext associated with the instance. Can be null during shutdown.

[michaeln, 2015/01/12 20:19:13]

where does it get set to nullptr?

+  BrowserContext* browser_context_;
 };
 
 }  // namespace content