Keep track of ServiceWorkerContext's BrowserContext and expose it.

content/browser/service_worker/service_worker_context_wrapper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_WRAPPER_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_WRAPPER_H_
 
 #include <vector>
 
 #include "base/files/file_path.h"
@@ skipping 70 matching lines @@
 
   // DeleteForOrigin with completion callback.  Does not exit early, and returns
   // false if one or more of the deletions fail.
   virtual void DeleteForOrigin(const GURL& origin_url,
                                const ResultCallback& done);
 
   void AddObserver(ServiceWorkerContextObserver* observer);
   void RemoveObserver(ServiceWorkerContextObserver* observer);
 
   bool is_incognito() const { return is_incognito_; }
+  BrowserContext* browser_context() const { return browser_context_; }

[michaeln, 2015/01/12 20:19:13]

Ah... I see why you're wanting to add this, to traverse back up the UI thread
object containment hierarchy,
wrapper->(partition->partitionmap)->browsercontext, for window opening purposes
that need the browsercontext.

The need to do that makes sense but how it's currently done in the CL doesn't
(for reasons stated in other comments).

I'd vote for something like this...

1. The wrapper has a StoragePartition* ptr and a getter. The getter DCHECKS it's
only called on the UI thread. The storeage_partition_ data member is cleared in
the Shutdown() method.

2. The StoragePartition class has a virtual getter for it's BrowserContext which
may return null during shutdown. The ptr is cleared in ~StoragePartitionImpl
prior to calling the various Shutdown() methods.

I think lets you traverse up to the browsercontext safely.

wdyt?

 
   // The URLRequestContext doesn't exist until after the StoragePartition is
   // made (which is after this object is made). This function must be called
   // after this object is created but before any ServiceWorkerCache operations.
   // It must be called on the IO thread. If either parameter is NULL the
   // function immediately returns without forwarding to the
   // ServiceWorkerCacheStorageManager.
   void SetBlobParametersForCache(
       net::URLRequestContextGetter* request_context,
       ChromeBlobStorageContext* blob_storage_context);
@@ skipping 22 matching lines @@
       const std::vector<ServiceWorkerRegistrationInfo>& registrations);
 
   const scoped_refptr<ObserverListThreadSafe<ServiceWorkerContextObserver> >
       observer_list_;
   const scoped_ptr<ServiceWorkerProcessManager> process_manager_;
   // Cleared in Shutdown():
   scoped_ptr<ServiceWorkerContextCore> context_core_;
 
   // Initialized in Init(); true if the user data directory is empty.
   bool is_incognito_;
+
+  // BrowserContext associated with the instance. Can be null during shutdown.

[michaeln, 2015/01/12 20:19:13]

where does it get set to nullptr?

+  BrowserContext* browser_context_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_CONTEXT_WRAPPER_H_