app_list: Re-enable people search.

app_list: Re-enable people search.

This feature was inadvertently removed in r311100.

BUG=449005
BUG=418072
Committed: https://crrev.com/2fbb6d9dedfa9ea73cba4c1ae6d86bf740a8fd6b
Cr-Commit-Position: refs/heads/master@{#311753}

[Matt Giuca, 2015-01-15 01:37:11]

mgiuca@chromium.org changed reviewers:
+ tapted@chromium.org

[Matt Giuca, 2015-01-15 01:37:12]

https://codereview.chromium.org/852053003/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/search/search_controller_factory.cc (right):

https://codereview.chromium.org/852053003/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/search/search_controller_factory.cc:59:
Mixer::PEOPLE_GROUP,
Note the wrapping here is different to the above... I've no idea why but
ClangFormat chooses to format this line differently. (Even if I re-run
ClangFormat over this whole block of code, it still formats this line
differently to the others.)

[tapted, 2015-01-15 01:45:34]

Perhaps add 418072 to BUG= as well

lgtm

https://codereview.chromium.org/852053003/diff/1/chrome/browser/ui/app_list/s...
File chrome/browser/ui/app_list/search/search_controller_factory.cc (right):

https://codereview.chromium.org/852053003/diff/1/chrome/browser/ui/app_list/s...
chrome/browser/ui/app_list/search/search_controller_factory.cc:59:
Mixer::PEOPLE_GROUP,
On 2015/01/15 01:37:11, Matt Giuca wrote:
> Note the wrapping here is different to the above... I've no idea why but
> ClangFormat chooses to format this line differently. (Even if I re-run
> ClangFormat over this whole block of code, it still formats this line
> differently to the others.)

I think more points are assigned to to not splitting the arguments to
PeopleProvider. I think s/WebstoreProvider/WebstoProvider/ would format that
like this too. (or `Omnibo`)

[Matt Giuca, 2015-01-15 02:50:17]

Thanks (I didn't find that bug because it wasn't linked from the original CL).

[Matt Giuca, 2015-01-15 02:52:08]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-01-15 02:53:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852053003/1

[commit-bot: I haz the power, 2015-01-15 03:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 03:52:13]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Matt Giuca, 2015-01-15 05:54:32]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-01-15 05:55:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852053003/1

[commit-bot: I haz the power, 2015-01-15 05:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-15 05:55:42]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Matt Giuca, 2015-01-15 22:56:26]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-01-15 22:58:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852053003/1

[commit-bot: I haz the power, 2015-01-15 23:03:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-15 23:05:11]

Patchset 1 (id:??) landed as
https://crrev.com/2fbb6d9dedfa9ea73cba4c1ae6d86bf740a8fd6b
Cr-Commit-Position: refs/heads/master@{#311753}