Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 852043003: lowlevel/img.sky flaky crashes (Closed)

Created:
5 years, 11 months ago by abarth-chromium
Modified:
5 years, 11 months ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

lowlevel/img.sky flaky crashes We don't need to pump pending speculations if we don't have any. R=esprehn@chromium.org, eseidel@chromium.org BUG=447763 Committed: https://chromium.googlesource.com/external/mojo/+/1ca63718c089f6221f196eeb6d93e921987d45f6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sky/engine/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 11 months ago (2015-01-14 18:41:44 UTC) #1
esprehn
lgtm https://codereview.chromium.org/852043003/diff/1/sky/engine/core/html/parser/HTMLDocumentParser.cpp File sky/engine/core/html/parser/HTMLDocumentParser.cpp (right): https://codereview.chromium.org/852043003/diff/1/sky/engine/core/html/parser/HTMLDocumentParser.cpp#newcode387 sky/engine/core/html/parser/HTMLDocumentParser.cpp:387: return; Why don't we always detach the parser ...
5 years, 11 months ago (2015-01-14 19:00:47 UTC) #3
abarth-chromium
https://codereview.chromium.org/852043003/diff/1/sky/engine/core/html/parser/HTMLDocumentParser.cpp File sky/engine/core/html/parser/HTMLDocumentParser.cpp (right): https://codereview.chromium.org/852043003/diff/1/sky/engine/core/html/parser/HTMLDocumentParser.cpp#newcode387 sky/engine/core/html/parser/HTMLDocumentParser.cpp:387: return; Oops. This branch shouldn't be here. That was ...
5 years, 11 months ago (2015-01-14 19:04:11 UTC) #4
abarth-chromium
5 years, 11 months ago (2015-01-14 21:32:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ca63718c089f6221f196eeb6d93e921987d45f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698