lowlevel/img.sky flaky crashes

sky/engine/core/html/parser/HTMLDocumentParser.cpp

Index: sky/engine/core/html/parser/HTMLDocumentParser.cpp
diff --git a/sky/engine/core/html/parser/HTMLDocumentParser.cpp b/sky/engine/core/html/parser/HTMLDocumentParser.cpp
index ae830ca6ead3148e55477d73357d35ff94b44158..7398c90c77a90dd44b540ec65531853d54f80e0d 100644
--- a/sky/engine/core/html/parser/HTMLDocumentParser.cpp
+++ b/sky/engine/core/html/parser/HTMLDocumentParser.cpp
@@ -383,11 +383,15 @@ bool HTMLDocumentParser::isWaitingForScripts() const
 
 void HTMLDocumentParser::resumeAfterWaitingForImports()
 {
+    if (isStopped())
+        return;

[esprehn, 2015/01/14 19:00:47]

Why don't we always detach the parser when stopping it? The comment here:

https://github.com/domokit/mojo/blob/f990d6d37b72dfb491d7b9f266f258ec31b6027f...

seems like we should. Strangely it seems like we stop the parser before firing
unload events, and detach it later.

If we unified detach and stop we could make this ASSERT(isStopped());

[abarth-chromium, 2015/01/14 19:04:11]

Oops.  This branch shouldn't be here.  That was just something I did for
debugging.  I'll remove it.

     RefPtr<HTMLDocumentParser> protect(this);
     if (m_scriptRunner.hasPendingScripts())
         m_scriptRunner.executePendingScripts();
     ASSERT(!isExecutingScript());
     ASSERT(!isWaitingForScripts());
+    if (m_speculations.isEmpty())
+        return;
     ASSERT(m_haveBackgroundParser);
     pumpPendingSpeculations();
 }