Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: Source/core/html/track/vtt/VTTCue.idl

Issue 851933003: WebVTT: Support 'auto' text position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop questionmark. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/vtt/VTTCue.idl
diff --git a/Source/core/html/track/vtt/VTTCue.idl b/Source/core/html/track/vtt/VTTCue.idl
index 3ca0307dfa3833e35322b1a45a7ae1140a27cb27..6c133c021eb7f2c54147f6fd737b5aa404fde685 100644
--- a/Source/core/html/track/vtt/VTTCue.idl
+++ b/Source/core/html/track/vtt/VTTCue.idl
@@ -27,6 +27,7 @@
* OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+enum AutoKeyword { "auto" };
enum DirectionSetting { "" /* horizontal */, "rl", "lr" };
enum AlignSetting { "start", "middle", "end", "left", "right" };
@@ -39,7 +40,8 @@ enum AlignSetting { "start", "middle", "end", "left", "right" };
attribute DirectionSetting vertical;
attribute boolean snapToLines;
[RaisesException=Setter] attribute long line;
philipj_slow 2015/01/15 09:08:57 How about line and size? I think grouping the long
fs 2015/01/15 10:07:16 Yes, I was thinking about that too... I guess this
philipj_slow 2015/01/19 14:44:26 Split it is!
- [RaisesException=Setter] attribute long position;
+ // FIXME: DOMString should be AutoKeyword. (crbug.com/240176)
philipj_slow 2015/01/15 09:08:57 Can you comment on the bug so that this specific c
fs 2015/01/15 10:07:16 I added a comment in the "IDL status" doc, and bas
philipj_slow 2015/01/19 14:44:26 Thanks!
fs 2015/01/19 15:09:06 (This is now supported, so expect this FIXME to di
+ [RaisesException=Setter] attribute (double or DOMString) position;
philipj_slow 2015/01/15 09:08:57 Can you also add TypeChecking=Unrestricted to the
fs 2015/01/15 10:07:16 Good catch.
[RaisesException=Setter] attribute long size;
attribute AlignSetting align;
attribute DOMString text;
« Source/core/html/track/vtt/VTTCue.cpp ('K') | « Source/core/html/track/vtt/VTTCue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698