WebVTT: Support 'auto' text position

Source/core/html/track/vtt/VTTCue.idl

 /*
  * Copyright (c) 2013, Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. Neither the name of Opera Software ASA nor the names of its
  *    contributors may be used to endorse or promote products derived
  *    from this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
  * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
  * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
  * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
  * OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+enum AutoKeyword { "auto" };
 enum DirectionSetting { "" /* horizontal */, "rl", "lr" };
 enum AlignSetting { "start", "middle", "end", "left", "right" };
 
 [
     Constructor(double startTime, double endTime, DOMString text),
     ConstructorCallWith=Document,
     SetWrapperReferenceFrom=owner,
 ] interface VTTCue : TextTrackCue {
     [RuntimeEnabled=WebVTTRegions] attribute DOMString regionId;
     attribute DirectionSetting vertical;
     attribute boolean snapToLines;
     [RaisesException=Setter] attribute long line;

[philipj_slow, 2015/01/15 09:08:57]

How about line and size? I think grouping the long->double in line/position/size
into one CL and the introduction of AutoKeyword for line/position in another one
would make the most sense. Probably long->double as the first CL will be
cleanest.

[fs, 2015/01/15 10:07:16]

Yes, I was thinking about that too... I guess this goes together with the
comment about double vs. float representable values, as it begs the question of
internal representation.
As for AutoKeyword I guess 'line' could be folded into this CL since it should
be mostly trivial since algorithm part is implemented already - but the
test-changes might be daunting enough to warrant a split (I think I'd prefer the
split approach there). Thoughts?

[philipj_slow, 2015/01/19 14:44:26]

Split it is!

-    [RaisesException=Setter] attribute long position;
+    // FIXME: DOMString should be AutoKeyword. (crbug.com/240176)

[philipj_slow, 2015/01/15 09:08:57]

Can you comment on the bug so that this specific case can be prioritized?

[fs, 2015/01/15 10:07:16]

I added a comment in the "IDL status" doc, and bashi said he'd added it to his
list.

[philipj_slow, 2015/01/19 14:44:26]

Thanks!

[fs, 2015/01/19 15:09:06]

(This is now supported, so expect this FIXME to disappear when I upload the next
PS.)

+    [RaisesException=Setter] attribute (double or DOMString) position;

[philipj_slow, 2015/01/15 09:08:57]

Can you also add TypeChecking=Unrestricted to the interface and test what
happens when you set cue.position = Infinity/NaN?

[fs, 2015/01/15 10:07:16]

Good catch.

     [RaisesException=Setter] attribute long size;
     attribute AlignSetting align;
     attribute DOMString text;
     DocumentFragment getCueAsHTML();
 };