Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 851813002: Fixed and reenabled the flaky test "WebViewAPITest.TestAutosizeAfterNavigation". (Closed)

Created:
5 years, 11 months ago by paulmeyer
Modified:
5 years, 11 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed and reenabled the flaky test "WebViewAPITest.TestAutosizeAfterNavigation". TBR=creis@chromium.org Committed: https://crrev.com/647b4f1bd0905f7c0c4abfe5a97393112a103aa7 Cr-Commit-Position: refs/heads/master@{#313140}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased again. #

Patch Set 4 : Fixed test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
paulmeyer
+fsamuel@
5 years, 11 months ago (2015-01-13 22:30:10 UTC) #2
Fady Samuel
lgtm
5 years, 11 months ago (2015-01-13 22:32:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851813002/1
5 years, 11 months ago (2015-01-13 23:27:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/35731)
5 years, 11 months ago (2015-01-13 23:33:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851813002/60001
5 years, 11 months ago (2015-01-23 22:26:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/17823)
5 years, 11 months ago (2015-01-23 23:34:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851813002/80001
5 years, 11 months ago (2015-01-26 20:27:08 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 11 months ago (2015-01-26 21:40:44 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 21:41:39 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/647b4f1bd0905f7c0c4abfe5a97393112a103aa7
Cr-Commit-Position: refs/heads/master@{#313140}

Powered by Google App Engine
This is Rietveld 408576698