Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 851813002: Fixed and reenabled the flaky test "WebViewAPITest.TestAutosizeAfterNavigation". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.cc
diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc
index 19c3d90103f691a82872ac958bc68fd3ef9c5b00..aaadf50199d3c63eb17adb6a88df21507a5f6e95 100644
--- a/extensions/browser/guest_view/guest_view_base.cc
+++ b/extensions/browser/guest_view/guest_view_base.cc
@@ -292,6 +292,7 @@ void GuestViewBase::SetSize(const SetSizeParams& params) {
guest_sizer_->SizeContents(new_size);
}
+ DispatchOnResizeEvent(guest_size_, new_size);
guest_size_ = new_size;
}
@@ -407,6 +408,7 @@ void GuestViewBase::ElementSizeChanged(const gfx::Size& size) {
// Only resize if needed.
guest_sizer_->SizeContents(size);
+ DispatchOnResizeEvent(guest_size_, size);
guest_size_ = size;
}
@@ -414,14 +416,12 @@ WebContents* GuestViewBase::GetOwnerWebContents() const {
return owner_web_contents_;
}
-void GuestViewBase::GuestSizeChanged(const gfx::Size& old_size,
- const gfx::Size& new_size) {
- DispatchOnResizeEvent(old_size, new_size);
-
+void GuestViewBase::GuestSizeChanged(const gfx::Size& new_size) {
if (!auto_size_enabled_)
return;
+ GuestSizeChangedDueToAutoSize(guest_size_, new_size);
+ DispatchOnResizeEvent(guest_size_, new_size);
guest_size_ = new_size;
- GuestSizeChangedDueToAutoSize(old_size, new_size);
}
const GURL& GuestViewBase::GetOwnerSiteURL() const {
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.h ('k') | extensions/browser/guest_view/web_view/web_view_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698