Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 851723004: NaCl SDK] nacl_io: remove getcwd() implemenation (rely on glibc/newlib versions) (Closed)

Created:
5 years, 11 months ago by Sam Clegg
Modified:
5 years, 11 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl SDK] nacl_io: remove getcwd() implemenation (rely on glibc/newlib versions) The newlib version of getcwd in libnacl now supports passing NULL of buffer, and recent version of gtest will gracefully handle getcwd failure in static constructors so we no longer need our own getcwd implementation. This is the second attempt and landing this change. The first was reverted: https://codereview.chromium.org/756333005 R=bradnelson Committed: https://crrev.com/4fad785312ac90ea3dd6e34926f30adee442ff89 Cr-Commit-Position: refs/heads/master@{#311329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 1 chunk +1 line, -16 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getcwd.c View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
5 years, 11 months ago (2015-01-13 19:07:46 UTC) #1
bradn
lgtm
5 years, 11 months ago (2015-01-13 19:19:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851723004/1
5 years, 11 months ago (2015-01-13 20:16:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 21:34:00 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:35:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fad785312ac90ea3dd6e34926f30adee442ff89
Cr-Commit-Position: refs/heads/master@{#311329}

Powered by Google App Engine
This is Rietveld 408576698