Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 756333005: [NaCl SDK] nacl_io: remove getcwd() implemenation (rely on glibc/newlib versions) (Closed)

Created:
6 years ago by Sam Clegg
Modified:
6 years ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: remove getcwd() implemenation (rely on glibc/newlib versions) Previsouly we didn't have a working version of getcwd() in newlib (libnacl) but we do now. Secondly the resean for intercepting getcwd() directly was due to gtest calling this in a static constructor. gtest was recently changed to handle the failure of getcwd() under NaCl so this workaround is no longer needed. BUG=437075 Committed: https://crrev.com/cd49bee13b46af6a4768836b8f89707d0e15f1f6 Cr-Commit-Position: refs/heads/master@{#306220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_intercept.cc View 1 chunk +1 line, -16 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/getcwd.c View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years ago (2014-11-30 17:06:00 UTC) #2
binji
lgtm
6 years ago (2014-12-01 18:51:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/756333005/1
6 years ago (2014-12-01 18:59:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 19:02:21 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-01 19:03:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd49bee13b46af6a4768836b8f89707d0e15f1f6
Cr-Commit-Position: refs/heads/master@{#306220}

Powered by Google App Engine
This is Rietveld 408576698