tools/json_schema_compiler/cc_generator.py - Issue 851673003: Cleanup: Some simplifications in json_schema_compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/cc_generator.py

Issue 851673003: Cleanup: Some simplifications in json_schema_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_dart_tests

Patch Set: Add unit test for GetAsBinary. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/json_schema_compiler/cc_generator.py

diff --git a/tools/json_schema_compiler/cc_generator.py b/tools/json_schema_compiler/cc_generator.py

index 1d243f03b5ad30fc582e4fb5083a2367eefe1cb7..41e26967e777de54c32102044eae350795d62671 100644

--- a/tools/json_schema_compiler/cc_generator.py

+++ b/tools/json_schema_compiler/cc_generator.py

@@ -773,10 +773,11 @@ class _Generator(object):

failure_value,

is_ptr=is_ptr))

else:

- (c.Sblock('if (!%s) {' % self._util_cc_helper.PopulateArrayFromList(

- 'list',

- dst_var,

- is_ptr)))

+ c.Sblock('if (!%s) {' % self._util_cc_helper.PopulateArrayFromList(

+ 'list',

+ dst_var,

+ is_ptr,

+ items_are_binary = item_type.property_type == PropertyType.BINARY))

c.Concat(self._GenerateError(

'"unable to populate array \'%%(parent_key)s\'"'))

if is_ptr and self._generate_error_messages:

« base/values.h ('K') | « base/values_unittest.cc ('k') | tools/json_schema_compiler/util.h » ('j') | no next file with comments »