base/values.h - Issue 851673003: Cleanup: Some simplifications in json_schema_compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values.h

Issue 851673003: Cleanup: Some simplifications in json_schema_compiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_dart_tests

Patch Set: Add unit test for GetAsBinary. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/values.h

diff --git a/base/values.h b/base/values.h

index 4c22f3ddc3e24445ad85bb75bd648b1b0d8a0488..d228faad0697a7f5b36c850c1261e346e82a91fd 100644

--- a/base/values.h

+++ b/base/values.h

@@ -79,6 +79,7 @@ class BASE_EXPORT Value {

// If the current object can be converted into the given type, the value is

// returned through the |out_value| parameter and true is returned;

// otherwise, false is returned and |out_value| is unchanged.

+ virtual bool GetAsBinary(std::string* out_value) const;

Mark Mentovai 2015/01/14 14:39:59 Can you keep these methods sorted like the Type en

virtual bool GetAsBoolean(bool* out_value) const;

virtual bool GetAsInteger(int* out_value) const;

virtual bool GetAsDouble(double* out_value) const;

@@ -188,6 +189,7 @@ class BASE_EXPORT BinaryValue: public Value {

const char* GetBuffer() const { return buffer_.get(); }

// Overridden from Value:

+ bool GetAsBinary(std::string* out_value) const override;

BinaryValue* DeepCopy() const override;

bool Equals(const Value* other) const override;

« no previous file with comments | « no previous file | base/values.cc » ('j') | no next file with comments »