Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 851593002: Delete RenderSelectionInfo and other selection rect paint invalidation code. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete RenderSelectionInfo and other selection rect paint invalidation code. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f6666b9c02bb769b44610da0f6c3d1eb239b5921

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -280 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +5 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 2 chunks +0 lines, -6 lines 1 comment Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/engine/core/rendering/RenderSelectionInfo.h View 1 chunk +0 lines, -111 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 6 chunks +15 lines, -121 lines 3 comments Download

Messages

Total messages: 4 (1 generated)
ojan
https://codereview.chromium.org/851593002/diff/1/sky/engine/core/rendering/RenderLayer.h File sky/engine/core/rendering/RenderLayer.h (left): https://codereview.chromium.org/851593002/diff/1/sky/engine/core/rendering/RenderLayer.h#oldcode545 sky/engine/core/rendering/RenderLayer.h:545: IntRect m_blockSelectionGapsBounds; This member gets written, but is never ...
5 years, 11 months ago (2015-01-13 00:40:47 UTC) #2
esprehn
lgtm https://codereview.chromium.org/851593002/diff/1/sky/engine/core/rendering/RenderView.cpp File sky/engine/core/rendering/RenderView.cpp (right): https://codereview.chromium.org/851593002/diff/1/sky/engine/core/rendering/RenderView.cpp#newcode329 sky/engine/core/rendering/RenderView.cpp:329: ASSERT(paintInvalidationContainer); On 2015/01/13 at 00:40:47, ojan wrote: > ...
5 years, 11 months ago (2015-01-13 00:54:48 UTC) #3
ojan
5 years, 11 months ago (2015-01-13 01:08:41 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f6666b9c02bb769b44610da0f6c3d1eb239b5921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698