Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: sky/engine/core/rendering/RenderSelectionInfo.h

Issue 851593002: Delete RenderSelectionInfo and other selection rect paint invalidation code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderSelectionInfo.h
diff --git a/sky/engine/core/rendering/RenderSelectionInfo.h b/sky/engine/core/rendering/RenderSelectionInfo.h
deleted file mode 100644
index 03e54f8e00eb1c246f7184814ca53ffc7356cb2c..0000000000000000000000000000000000000000
--- a/sky/engine/core/rendering/RenderSelectionInfo.h
+++ /dev/null
@@ -1,111 +0,0 @@
-/*
- * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
- * (C) 2000 Antti Koivisto (koivisto@kde.org)
- * (C) 2000 Dirk Mueller (mueller@kde.org)
- * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
- * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
- * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Library General Public License for more details.
- *
- * You should have received a copy of the GNU Library General Public License
- * along with this library; see the file COPYING.LIB. If not, write to
- * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- * Boston, MA 02110-1301, USA.
- *
- */
-
-#ifndef SKY_ENGINE_CORE_RENDERING_RENDERSELECTIONINFO_H_
-#define SKY_ENGINE_CORE_RENDERING_RENDERSELECTIONINFO_H_
-
-#include "sky/engine/core/rendering/RenderBox.h"
-#include "sky/engine/platform/geometry/IntRect.h"
-
-namespace blink {
-
-class RenderSelectionInfoBase {
- WTF_MAKE_NONCOPYABLE(RenderSelectionInfoBase); WTF_MAKE_FAST_ALLOCATED;
-public:
- RenderSelectionInfoBase()
- : m_object(nullptr)
- , m_paintInvalidationContainer(nullptr)
- , m_state(RenderObject::SelectionNone)
- {
- }
-
- RenderSelectionInfoBase(RenderObject* o)
- : m_object(o)
- , m_paintInvalidationContainer(o->containerForPaintInvalidation())
- , m_state(o->selectionState())
- {
- }
-
- RenderObject* object() const { return m_object; }
- const RenderLayerModelObject* paintInvalidationContainer() const { return m_paintInvalidationContainer; }
- RenderObject::SelectionState state() const { return m_state; }
-
-protected:
- RawPtr<RenderObject> m_object;
- RawPtr<const RenderLayerModelObject> m_paintInvalidationContainer;
- RenderObject::SelectionState m_state;
-};
-
-// FIXME(sky): Remove this class.
-// This struct is used when the selection changes to cache the old and new state of the selection for each RenderObject.
-class RenderSelectionInfo final : public RenderSelectionInfoBase {
-public:
- RenderSelectionInfo(RenderObject* o, bool clipToVisibleContent)
- : RenderSelectionInfoBase(o)
- {
- if (o->canUpdateSelectionOnRootLineBoxes()) {
- m_rect = o->selectionRectForPaintInvalidation(m_paintInvalidationContainer, clipToVisibleContent);
- } else {
- m_rect = LayoutRect();
- }
- }
-
- void invalidatePaint()
- {
- }
-
- LayoutRect rect() const { return m_rect; }
-
-private:
- LayoutRect m_rect; // relative to paint invalidation container
-};
-
-// FIXME(sky): Remove this class.
-// This struct is used when the selection changes to cache the old and new state of the selection for each RenderBlock.
-class RenderBlockSelectionInfo final : public RenderSelectionInfoBase {
-public:
- RenderBlockSelectionInfo(RenderBlock* b)
- : RenderSelectionInfoBase(b)
- {
- if (b->canUpdateSelectionOnRootLineBoxes())
- m_rects = block()->selectionGapRectsForPaintInvalidation(m_paintInvalidationContainer);
- else
- m_rects = GapRects();
- }
-
- void invalidatePaint()
- {
- }
-
- RenderBlock* block() const { return toRenderBlock(m_object); }
- GapRects rects() const { return m_rects; }
-
-private:
- GapRects m_rects; // relative to paint invalidation container
-};
-
-} // namespace blink
-
-
-#endif // SKY_ENGINE_CORE_RENDERING_RENDERSELECTIONINFO_H_

Powered by Google App Engine
This is Rietveld 408576698