Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: public/web/WebViewClient.h

Issue 851393002: add previously focused node to WebClient::focusedNodeChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: dont break chrome Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/ChromeClientImpl.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index 908bbdb34545988de0589ab7f242653ccc0a4a1f..92b46569b62cb16909e63d47c283627d8c384106 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -186,8 +186,11 @@ public:
virtual void focusNext() { }
virtual void focusPrevious() { }
- // Called when a new node gets focused.
+ // TODO(estade): remove this function.
Mike West 2015/01/19 08:52:16 Totally tiny nit: We use FIXME in Blink.
Evan Stade 2015/01/20 22:23:54 Done.
virtual void focusedNodeChanged(const WebNode&) { }
+ // Called when a new node gets focused. First argument is the previously focused node, the
+ // second is the newly focused node. Either can be null.
+ virtual void focusedNodeChanged(const WebNode&, const WebNode&) { }
dmazzoni 2015/01/20 07:31:52 Nit: Blink leaves out argument names in header fil
Evan Stade 2015/01/20 22:23:54 Done.
// Indicates two things:
// 1) This view may have a new layout now.
« Source/web/ChromeClientImpl.cpp ('K') | « Source/web/ChromeClientImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698