Source/web/ChromeClientImpl.cpp - Issue 851393002: add previously focused node to WebClient::focusedNodeChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 851393002: add previously focused node to WebClient::focusedNodeChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: dont break chrome Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index f59cc5f67e7a3b96641135678b6269a6bdba4a8c..d780dfb13be157785d704cb0434429460838d925 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -197,13 +197,15 @@ void ChromeClientImpl::takeFocus(FocusType type)

m_webView->client()->focusNext();

}

-void ChromeClientImpl::focusedNodeChanged(Node* node)

+void ChromeClientImpl::focusedNodeChanged(Node* previouslyFocusedNode, Node* focusedNode)

{

- m_webView->client()->focusedNodeChanged(WebNode(node));

+ // TODO(estade): remove.

Mike West 2015/01/19 08:52:16 Totally tiny nit: We use FIXME in Blink.

Evan Stade 2015/01/20 22:23:54 Done.

+ m_webView->client()->focusedNodeChanged(WebNode(focusedNode));

+ m_webView->client()->focusedNodeChanged(WebNode(previouslyFocusedNode), WebNode(focusedNode));

WebURL focusURL;

- if (node && node->isElementNode() && toElement(node)->isLiveLink())

- focusURL = toElement(node)->hrefURL();

+ if (focusedNode && focusedNode->isElementNode() && toElement(focusedNode)->isLiveLink())

+ focusURL = toElement(focusedNode)->hrefURL();

m_webView->client()->setKeyboardFocusURL(focusURL);

}

« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | public/web/WebViewClient.h » ('j') | public/web/WebViewClient.h » ('J')